[RFA/Obvious] AR Index abort function use rule fix

[RFA/Obvious] AR Index abort function use rule fix

[Pierre Muller]

Current ARI shows a regression on 
use of abort function.
 This is related to the fact that there
are four usages of abort () in utils.c
but gdb_ari.sh only lists 3.
$ grep -w abort utils.c
utils.c:        abort ();       /* NOTE: GDB has only four calls to abort().
*/
utils.c:          abort (); /* NOTE: GDB has only four calls to abort().  */
utils.c:        abort ();               /* NOTE: GDB has only four calls to
abort().  */
utils.c:            abort ();           /* NOTE: GDB has only four calls to
abort().  */

  I would have committed this myself under obvious rule,
but the problem is that I have no write permission to
this folder anymore...

Commit entry log:
	* gdb_ari.sh (abort rule): Change number of expected
	abort occurrences in utils.c to 4.

  Daniel, is this OK?
If yes, could you check it in for me?


Pierre Muller
Pascal language support maintainer for GDB



$ cvs diff -up gdb_ari.sh
Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.78
diff -u -p -r1.78 gdb_ari.sh
--- gdb_ari.sh  18 Mar 2009 02:57:33 -0000      1.78
+++ gdb_ari.sh  23 Mar 2009 12:41:59 -0000
@@ -563,7 +563,7 @@ Replace obj_private with objfile_data"
 BEGIN { doc["abort"] = "\
 Do not use abort, instead use internal_error; GDB should never abort"
     category["abort"] = ari_regression
-    fix("abort", "gdb/utils.c", 3)
+    fix("abort", "gdb/utils.c", 4)
 }
 /(^|[^_[:alnum:]])abort[[:space:]]*\(/ {
     fail("abort")

Re: [RFA/Obvious] AR Index abort function use rule fix

[Joel Brobecker]

>   I would have committed this myself under obvious rule,
> but the problem is that I have no write permission to
> this folder anymore...

Do you see yourself making changes to this scripts once in a while?
Apart from a Daniel, you're pretty much the only one to have made
some regular changes to this file. If you are going to continue to
make changes, it would make sense to give you access to this repo.

> 	* gdb_ari.sh (abort rule): Change number of expected
> 	abort occurrences in utils.c to 4.
> 
>   Daniel, is this OK?
> If yes, could you check it in for me?

The extra call to abort was add by Jim Blandy, and was OKed.
So you change makes sense. I will check it in for you since I'm about
to check your other pending change as well.

Thanks for the patch.

-- 
Joel

Re: [RFA/Obvious] AR Index abort function use rule fix

[Joel Brobecker]

> 	* gdb_ari.sh (abort rule): Change number of expected
> 	abort occurrences in utils.c to 4.

Checked in.

-- 
Joel

RE: [RFA/Obvious] AR Index abort function use rule fix

[Pierre Muller]

> -----Message d'origine-----
> De : Joel Brobecker [mailto:brobecker@adacore.com]
> Envoyé : Monday, March 23, 2009 3:30 PM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org; 'Daniel Jacobowitz'
> Objet : Re: [RFA/Obvious] AR Index abort function use rule fix
> 
> >   I would have committed this myself under obvious rule,
> > but the problem is that I have no write permission to
> > this folder anymore...
> 
> Do you see yourself making changes to this scripts once in a while?
> Apart from a Daniel, you're pretty much the only one to have made
> some regular changes to this file. If you are going to continue to
> make changes, it would make sense to give you access to this repo.
  
  I would like this, but I don't know if it is possible.

Pierre Muller
Pascal language support maintainer for GDB

Re: [RFA/Obvious] AR Index abort function use rule fix

[Joel Brobecker]

> > Do you see yourself making changes to this scripts once in a while?
> > Apart from a Daniel, you're pretty much the only one to have made
> > some regular changes to this file. If you are going to continue to
> > make changes, it would make sense to give you access to this repo.
>   
>   I would like this, but I don't know if it is possible.

Pierre, you should now have checkin permission. I guess you now have
to make another enhancement to verify that it works :).

I'll contact you privately about what needs to be done once the change
is checked in.

-- 
Joel