From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>, "'Daniel Jacobowitz'" <drow@false.org>
Subject: [RFA/Obvious] AR Index abort function use rule fix
Date: Mon, 23 Mar 2009 14:23:00 -0000 [thread overview]
Message-ID: <000a01c9abb5$c2a5b600$47f12200$@u-strasbg.fr> (raw)
Current ARI shows a regression on
use of abort function.
This is related to the fact that there
are four usages of abort () in utils.c
but gdb_ari.sh only lists 3.
$ grep -w abort utils.c
utils.c: abort (); /* NOTE: GDB has only four calls to abort().
*/
utils.c: abort (); /* NOTE: GDB has only four calls to abort(). */
utils.c: abort (); /* NOTE: GDB has only four calls to
abort(). */
utils.c: abort (); /* NOTE: GDB has only four calls to
abort(). */
I would have committed this myself under obvious rule,
but the problem is that I have no write permission to
this folder anymore...
Commit entry log:
* gdb_ari.sh (abort rule): Change number of expected
abort occurrences in utils.c to 4.
Daniel, is this OK?
If yes, could you check it in for me?
Pierre Muller
Pascal language support maintainer for GDB
$ cvs diff -up gdb_ari.sh
Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.78
diff -u -p -r1.78 gdb_ari.sh
--- gdb_ari.sh 18 Mar 2009 02:57:33 -0000 1.78
+++ gdb_ari.sh 23 Mar 2009 12:41:59 -0000
@@ -563,7 +563,7 @@ Replace obj_private with objfile_data"
BEGIN { doc["abort"] = "\
Do not use abort, instead use internal_error; GDB should never abort"
category["abort"] = ari_regression
- fix("abort", "gdb/utils.c", 3)
+ fix("abort", "gdb/utils.c", 4)
}
/(^|[^_[:alnum:]])abort[[:space:]]*\(/ {
fail("abort")
next reply other threads:[~2009-03-23 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 14:23 Pierre Muller [this message]
2009-03-23 14:37 ` Joel Brobecker
2009-03-23 15:38 ` Pierre Muller
2009-03-23 18:07 ` Joel Brobecker
2009-03-23 14:45 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000a01c9abb5$c2a5b600$47f12200$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox