From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2113 invoked by alias); 23 Mar 2009 12:49:16 -0000 Received: (qmail 2105 invoked by uid 22791); 23 Mar 2009 12:49:15 -0000 X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM,HK_OBFDOMREQ X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Mar 2009 12:49:10 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n2NCn2Oq085705 ; Mon, 23 Mar 2009 13:49:02 +0100 (CET) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n2NCn2rR009102 ; Mon, 23 Mar 2009 13:49:02 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n2NCn2qp071074 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Mon, 23 Mar 2009 13:49:02 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: , "'Daniel Jacobowitz'" Subject: [RFA/Obvious] AR Index abort function use rule fix Date: Mon, 23 Mar 2009 14:23:00 -0000 Message-ID: <000a01c9abb5$c2a5b600$47f12200$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00484.txt.bz2 Current ARI shows a regression on use of abort function. This is related to the fact that there are four usages of abort () in utils.c but gdb_ari.sh only lists 3. $ grep -w abort utils.c utils.c: abort (); /* NOTE: GDB has only four calls to abort(). */ utils.c: abort (); /* NOTE: GDB has only four calls to abort(). */ utils.c: abort (); /* NOTE: GDB has only four calls to abort(). */ utils.c: abort (); /* NOTE: GDB has only four calls to abort(). */ I would have committed this myself under obvious rule, but the problem is that I have no write permission to this folder anymore... Commit entry log: * gdb_ari.sh (abort rule): Change number of expected abort occurrences in utils.c to 4. Daniel, is this OK? If yes, could you check it in for me? Pierre Muller Pascal language support maintainer for GDB $ cvs diff -up gdb_ari.sh Index: gdb_ari.sh =================================================================== RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v retrieving revision 1.78 diff -u -p -r1.78 gdb_ari.sh --- gdb_ari.sh 18 Mar 2009 02:57:33 -0000 1.78 +++ gdb_ari.sh 23 Mar 2009 12:41:59 -0000 @@ -563,7 +563,7 @@ Replace obj_private with objfile_data" BEGIN { doc["abort"] = "\ Do not use abort, instead use internal_error; GDB should never abort" category["abort"] = ari_regression - fix("abort", "gdb/utils.c", 3) + fix("abort", "gdb/utils.c", 4) } /(^|[^_[:alnum:]])abort[[:space:]]*\(/ { fail("abort")