RE: TR: ARI warning list change Fri May 29 01:53:26 UTC 2009

["Pierre Muller" <muller@ics.u-strasbg.fr>]

Sorry,

The ARI stands for Awk Regression index
and is a script (named gdb_ari.sh) that is run once a day by
the machine on which the webite is.

The result of this script is transformed into a web page:
http://sourceware.org/gdb/current/ari/

Most used files are accessible at the bottom of the web page,
in particular gdb_ari.sh is at:
http://sourceware.org/gdb/current/ari/gdb_ari.sh


A recent change I made adds a email generation that is
only sent to me until now, but I was trying to
get this sent to gdb-testers.
The email message can be seen of the website:
http://sourceware.org/gdb/current/ari/mail-message

This message shows the differences between
yesterday's and today's list of warnings generated by gdb_ari.sh.


The email that I got this night was
>>>>>>>>>>Current version of email message
657a658,659
> gdb/mi/mi-cmd-var.c:251: gettext: _ markup: All messages should be marked
up with _.
> gdb/mi/mi-cmd-var.c:256: gettext: _ markup: All messages should be marked
up with _.
837a840,846
> gdb/varobj.c:853: gettext: _ markup: All messages should be marked up with
_.
> gdb/varobj.c:859: gettext: _ markup: All messages should be marked up with
_.
> gdb/varobj.c:865: gettext: _ markup: All messages should be marked up with
_.
> gdb/varobj.c:882: gettext: _ markup: All messages should be marked up with
_.
> gdb/varobj.c:1386: gettext: _ markup: All messages should be marked up
with _.
> gdb/varobj.c:1457: gettext: _ markup: All messages should be marked up
with _.
> gdb/varobj.c:1470: gettext: _ markup: All messages should be marked up
with _.
1204d1212
< gdb/value.c:529: deprecated: deprecated value_address_hack: Do not use
deprecated value_address_hack, see declaration for details
1395,1396d1402
< gdb/value.h:278: deprecated: deprecated value_address_hack: Do not use
deprecated value_address_hack, see declaration for details
< gdb/value.h:279: deprecated: deprecated value_address_hack: Do not use
deprecated value_address_hack, see declaration for details
>>>>>>>>>>End of current version of email message

This shows that your patch generated new warnings,
but also removed three warnings about the deprecated use of
value_address_hack
that is completely removed. This is great.

  But it also lists several positions,
with file source and line number of
additional warnings. For that patch all new warnings
are of the same kind. This is one of the rules checked
by gdb_ari.sh that verifies that all constant messages
are enclosed in _() markers for internalization.

  As you pointed out, the mi code might be unsuitable
for these markers, but I suppose that for the gdb/varobj.c

  A newer version of update-web-ari (that I didn't commit yet)
improves the email by also listing the corresponding source line:
>>>>>>>>>>New version of email message
941a942,943
> gdb/mi/mi-cmd-var.c:251: gettext: _ markup: All messages should be marked
up with _.
gdb/mi/mi-cmd-var.c:251:    error ("Usage: NAME VISUALIZER_FUNCTION.");
> gdb/mi/mi-cmd-var.c:256: gettext: _ markup: All messages should be marked
up with _.
gdb/mi/mi-cmd-var.c:256:    error ("Variable object not found");
1724d1725
< gdb/value.c:529: deprecated: deprecated value_address_hack: Do not use
deprecated value_address_hack, see declaration for details
gdb/value.c:529:deprecated_value_address_hack (struct value *value)
1735,1736d1735
< gdb/value.h:278: deprecated: deprecated value_address_hack: Do not use
deprecated value_address_hack, see declaration for details
gdb/value.h:278:extern CORE_ADDR *deprecated_value_address_hack (struct
value *);
< gdb/value.h:279: deprecated: deprecated value_address_hack: Do not use
deprecated value_address_hack, see declaration for details
gdb/value.h:279:#define VALUE_ADDRESS(val) (*deprecated_value_address_hack
(val))
1742a1742,1748
> gdb/varobj.c:853: gettext: _ markup: All messages should be marked up with
_.
gdb/varobj.c:853:      error ("Null value returned for children");
> gdb/varobj.c:859: gettext: _ markup: All messages should be marked up with
_.
gdb/varobj.c:859:    error ("Returned value is not iterable");
> gdb/varobj.c:865: gettext: _ markup: All messages should be marked up with
_.
gdb/varobj.c:865:      error ("Could not get children iterator");
> gdb/varobj.c:882: gettext: _ markup: All messages should be marked up with
_.
gdb/varobj.c:882:	error ("Invalid item from the child list");
> gdb/varobj.c:1386: gettext: _ markup: All messages should be marked up
with _.
gdb/varobj.c:1386:  error ("Python support required");
> gdb/varobj.c:1457: gettext: _ markup: All messages should be marked up
with _.
gdb/varobj.c:1457:      error ("Could not evaluate visualizer expression:
%s", visualizer);
> gdb/varobj.c:1470: gettext: _ markup: All messages should be marked up
with _.
gdb/varobj.c:1470:  error ("Python support required");
>>>>>>>>>>End of new version of email message 
  
  By looking at this I tend to think that these messages
should indeed be translated if we ever translate gdb...

 I hope this explains a little bit what ARI is all about.

Pierre