From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3116 invoked by alias); 29 May 2009 09:43:10 -0000 Received: (qmail 3102 invoked by uid 22791); 29 May 2009 09:43:09 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 May 2009 09:43:00 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n4T9gKe5010345 ; Fri, 29 May 2009 11:42:20 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n4T9gJnI038958 ; Fri, 29 May 2009 11:42:19 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n4T9gIfv063010 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Fri, 29 May 2009 11:42:18 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Vladimir Prus'" Cc: , "'Thiago Jung Bauermann'" , References: <000001c9e02a$034bb030$09e31090$@u-strasbg.fr> <200905291140.18693.vladimir@codesourcery.com> <000601c9e037$de6565a0$9b3030e0$@u-strasbg.fr> <200905291309.11553.vladimir@codesourcery.com> In-Reply-To: <200905291309.11553.vladimir@codesourcery.com> Subject: RE: TR: ARI warning list change Fri May 29 01:53:26 UTC 2009 Date: Fri, 29 May 2009 09:43:00 -0000 Message-ID: <000901c9e041$c517b0d0$4f471270$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00619.txt.bz2 Sorry, The ARI stands for Awk Regression index and is a script (named gdb_ari.sh) that is run once a day by the machine on which the webite is. The result of this script is transformed into a web page: http://sourceware.org/gdb/current/ari/ Most used files are accessible at the bottom of the web page, in particular gdb_ari.sh is at: http://sourceware.org/gdb/current/ari/gdb_ari.sh A recent change I made adds a email generation that is only sent to me until now, but I was trying to get this sent to gdb-testers. The email message can be seen of the website: http://sourceware.org/gdb/current/ari/mail-message This message shows the differences between yesterday's and today's list of warnings generated by gdb_ari.sh. The email that I got this night was >>>>>>>>>>Current version of email message 657a658,659 > gdb/mi/mi-cmd-var.c:251: gettext: _ markup: All messages should be marked up with _. > gdb/mi/mi-cmd-var.c:256: gettext: _ markup: All messages should be marked up with _. 837a840,846 > gdb/varobj.c:853: gettext: _ markup: All messages should be marked up with _. > gdb/varobj.c:859: gettext: _ markup: All messages should be marked up with _. > gdb/varobj.c:865: gettext: _ markup: All messages should be marked up with _. > gdb/varobj.c:882: gettext: _ markup: All messages should be marked up with _. > gdb/varobj.c:1386: gettext: _ markup: All messages should be marked up with _. > gdb/varobj.c:1457: gettext: _ markup: All messages should be marked up with _. > gdb/varobj.c:1470: gettext: _ markup: All messages should be marked up with _. 1204d1212 < gdb/value.c:529: deprecated: deprecated value_address_hack: Do not use deprecated value_address_hack, see declaration for details 1395,1396d1402 < gdb/value.h:278: deprecated: deprecated value_address_hack: Do not use deprecated value_address_hack, see declaration for details < gdb/value.h:279: deprecated: deprecated value_address_hack: Do not use deprecated value_address_hack, see declaration for details >>>>>>>>>>End of current version of email message This shows that your patch generated new warnings, but also removed three warnings about the deprecated use of value_address_hack that is completely removed. This is great. But it also lists several positions, with file source and line number of additional warnings. For that patch all new warnings are of the same kind. This is one of the rules checked by gdb_ari.sh that verifies that all constant messages are enclosed in _() markers for internalization. As you pointed out, the mi code might be unsuitable for these markers, but I suppose that for the gdb/varobj.c A newer version of update-web-ari (that I didn't commit yet) improves the email by also listing the corresponding source line: >>>>>>>>>>New version of email message 941a942,943 > gdb/mi/mi-cmd-var.c:251: gettext: _ markup: All messages should be marked up with _. gdb/mi/mi-cmd-var.c:251: error ("Usage: NAME VISUALIZER_FUNCTION."); > gdb/mi/mi-cmd-var.c:256: gettext: _ markup: All messages should be marked up with _. gdb/mi/mi-cmd-var.c:256: error ("Variable object not found"); 1724d1725 < gdb/value.c:529: deprecated: deprecated value_address_hack: Do not use deprecated value_address_hack, see declaration for details gdb/value.c:529:deprecated_value_address_hack (struct value *value) 1735,1736d1735 < gdb/value.h:278: deprecated: deprecated value_address_hack: Do not use deprecated value_address_hack, see declaration for details gdb/value.h:278:extern CORE_ADDR *deprecated_value_address_hack (struct value *); < gdb/value.h:279: deprecated: deprecated value_address_hack: Do not use deprecated value_address_hack, see declaration for details gdb/value.h:279:#define VALUE_ADDRESS(val) (*deprecated_value_address_hack (val)) 1742a1742,1748 > gdb/varobj.c:853: gettext: _ markup: All messages should be marked up with _. gdb/varobj.c:853: error ("Null value returned for children"); > gdb/varobj.c:859: gettext: _ markup: All messages should be marked up with _. gdb/varobj.c:859: error ("Returned value is not iterable"); > gdb/varobj.c:865: gettext: _ markup: All messages should be marked up with _. gdb/varobj.c:865: error ("Could not get children iterator"); > gdb/varobj.c:882: gettext: _ markup: All messages should be marked up with _. gdb/varobj.c:882: error ("Invalid item from the child list"); > gdb/varobj.c:1386: gettext: _ markup: All messages should be marked up with _. gdb/varobj.c:1386: error ("Python support required"); > gdb/varobj.c:1457: gettext: _ markup: All messages should be marked up with _. gdb/varobj.c:1457: error ("Could not evaluate visualizer expression: %s", visualizer); > gdb/varobj.c:1470: gettext: _ markup: All messages should be marked up with _. gdb/varobj.c:1470: error ("Python support required"); >>>>>>>>>>End of new version of email message By looking at this I tend to think that these messages should indeed be translated if we ever translate gdb... I hope this explains a little bit what ARI is all about. Pierre