From: Michael Jeanson via lttng-dev <lttng-dev@lists.lttng.org>
To: lttng-dev@lists.lttng.org
Subject: Re: [lttng-dev] Change to CPU number detection breaks QNX compilation
Date: Mon, 15 Aug 2022 09:53:44 -0400 [thread overview]
Message-ID: <dd0df1d0-12ed-a568-839e-7d2ff1fbcff7@efficios.com> (raw)
In-Reply-To: <CAJbg=FUXDnq0cSLCzhOAO4W44+monQF4s73t_sT4dAPGWt8fPg@mail.gmail.com>
On 2022-08-13 19 h 10, Elad Lahav via lttng-dev wrote:
> Hello,
>
> I have just downloaded and built the library for QNX/aarch64 and
> noticed that the code in compat-smp.h breaks the build. This file
> appears to be a (very) recent addition, from this commit:
>
> ---
> commit 5cfe81b7ddff9543d451746de9965cac58c67182
> Author: Michael Jeanson <mjeanson@efficios.com>
> Date: Wed Jul 27 10:44:00 2022 -0400
>
> fix: sysconf(_SC_NPROCESSORS_CONF) can be less than max cpu id
>
> ---
>
> I started working around it, but it got a bit ugly. Is the change not
> a Linuxism? Does it make sense on other systems? If QNX is the
> exception then I can try to come up with a patch, but if not perhaps
> the entire code should be wrapped by #ifdef __linux__?
>
> --Elad
Hi,
We'll need more details on the build failure you are seeing, there is
already an '#ifdef __linux__' in 'src/compat-smp.h'.
Can you send the relevant build errors?
Michael
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2022-08-15 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 23:10 Elad Lahav via lttng-dev
2022-08-15 13:53 ` Michael Jeanson via lttng-dev [this message]
[not found] ` <CAJbg=FWjjBT1RbGxvCcx1+6qgJfhqtF3h3WpLB11cGSb1Efzqw@mail.gmail.com>
2022-08-15 15:55 ` Michael Jeanson via lttng-dev
2022-08-15 16:56 ` Elad Lahav via lttng-dev
2022-08-15 17:39 ` Michael Jeanson via lttng-dev
2022-08-15 17:52 ` Elad Lahav via lttng-dev
2022-08-16 15:20 ` Michael Jeanson via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd0df1d0-12ed-a568-839e-7d2ff1fbcff7@efficios.com \
--to=lttng-dev@lists.lttng.org \
--cc=mjeanson@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox