From: Elad Lahav via lttng-dev <lttng-dev@lists.lttng.org>
To: Michael Jeanson <mjeanson@efficios.com>
Cc: lttng-dev@lists.lttng.org
Subject: Re: [lttng-dev] Change to CPU number detection breaks QNX compilation
Date: Mon, 15 Aug 2022 13:52:03 -0400 [thread overview]
Message-ID: <CAJbg=FUVVfNkDM4xvmMtVtw+GCs2nXmbCT02BXoA+3Jd1Nc2cQ@mail.gmail.com> (raw)
In-Reply-To: <a5f31003-9cc9-33e3-5c23-e4360fe7edbf@efficios.com>
/bin/sh on QNX is (by default) ksh, not bash, so perhaps that's the issue.
Shouldn't block you from submitting that change. +1 from me, if that matters ;-)
--Elad
On Mon, 15 Aug 2022 at 13:39, Michael Jeanson <mjeanson@efficios.com> wrote:
>
> On 2022-08-15 12 h 56, Elad Lahav wrote:
> > That fixes the build, thanks.
> >
> > I see some errors coming out of "make check", though:
> >
> > ERROR: test_get_cpu_mask_from_sysfs - missing test plan
> > ERROR: test_get_cpu_mask_from_sysfs - exited with status 1
> >
> > --Elad
>
> I tested on Freebsd (as a non-linux target) and I get the expected :
>
> SKIP: test_get_cpu_mask_from_sysfs - Skip Linux specific tests.
>
> I wonder what might differ here, it might have to do with the version of
> bash on QNX, I'm not familiar with this platform.
>
> Michael
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2022-08-15 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 23:10 Elad Lahav via lttng-dev
2022-08-15 13:53 ` Michael Jeanson via lttng-dev
[not found] ` <CAJbg=FWjjBT1RbGxvCcx1+6qgJfhqtF3h3WpLB11cGSb1Efzqw@mail.gmail.com>
2022-08-15 15:55 ` Michael Jeanson via lttng-dev
2022-08-15 16:56 ` Elad Lahav via lttng-dev
2022-08-15 17:39 ` Michael Jeanson via lttng-dev
2022-08-15 17:52 ` Elad Lahav via lttng-dev [this message]
2022-08-16 15:20 ` Michael Jeanson via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJbg=FUVVfNkDM4xvmMtVtw+GCs2nXmbCT02BXoA+3Jd1Nc2cQ@mail.gmail.com' \
--to=lttng-dev@lists.lttng.org \
--cc=e2lahav@gmail.com \
--cc=mjeanson@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox