From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ycKYNexP+mJOYicAWB0awg (envelope-from ) for ; Mon, 15 Aug 2022 09:53:48 -0400 Received: by simark.ca (Postfix, from userid 112) id CF4C91E5EA; Mon, 15 Aug 2022 09:53:48 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=lists.lttng.org header.i=@lists.lttng.org header.a=rsa-sha256 header.s=default header.b=i/gh4+5g; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.lttng.org (lists.lttng.org [167.114.26.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8BA071E13B for ; Mon, 15 Aug 2022 09:53:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.lttng.org; s=default; t=1660571628; bh=N81pzfD5Gvb7dcjIZtzNniK2IGr+aG1C+CE3dznB2TU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=i/gh4+5glgiSGmFr8sEpJBayYX8zU5YZueV4+Dp6Kn8d8hGAayJL3Bf4sdOHGRmn1 U7S6ganZW+B1aOGyzckB4wfz+U2kBoPhDemD0nuwfZ8ho3+gDX2zSVpoKCa+BnQuOh jaa+ozraqEF3urPvAckvz8VuNH4h9FDmOssJo/wgBUwgHQ9PQI3w5uHSgvHW9TizMo 4r27BzW4HA6/mediIQTNKK8/bbAKDvDvJJlbEjAk9C7eFb5zsB6eaq9EzL4o2uodHn bK4Hcde684x8DRt6j4U0We3Sfz4tSmaIxLVkUijBT/MTElWC08elVn4IM4Iw6ZRT4d MIuHu0yQcrtYw== Received: from lists-lttng01.efficios.com (localhost [IPv6:::1]) by lists.lttng.org (Postfix) with ESMTP id 4M5wjm0Gqpz1GkX; Mon, 15 Aug 2022 09:53:48 -0400 (EDT) Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by lists.lttng.org (Postfix) with ESMTPS id 4M5wjk0hF6z1GkR for ; Mon, 15 Aug 2022 09:53:45 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 666E3325117 for ; Mon, 15 Aug 2022 09:53:45 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id TrG7yiCf-qD5 for ; Mon, 15 Aug 2022 09:53:44 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id D1EFE3250A4 for ; Mon, 15 Aug 2022 09:53:44 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com D1EFE3250A4 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8IkizWCkQesU for ; Mon, 15 Aug 2022 09:53:44 -0400 (EDT) Received: from [10.10.0.55] (unknown [38.141.136.237]) by mail.efficios.com (Postfix) with ESMTPSA id B7508324F45 for ; Mon, 15 Aug 2022 09:53:44 -0400 (EDT) Message-ID: Date: Mon, 15 Aug 2022 09:53:44 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: lttng-dev@lists.lttng.org References: In-Reply-To: Subject: Re: [lttng-dev] Change to CPU number detection breaks QNX compilation X-BeenThere: lttng-dev@lists.lttng.org X-Mailman-Version: 2.1.39 Precedence: list List-Id: LTTng development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Michael Jeanson via lttng-dev Reply-To: Michael Jeanson Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: lttng-dev-bounces@lists.lttng.org Sender: "lttng-dev" On 2022-08-13 19 h 10, Elad Lahav via lttng-dev wrote: > Hello, > > I have just downloaded and built the library for QNX/aarch64 and > noticed that the code in compat-smp.h breaks the build. This file > appears to be a (very) recent addition, from this commit: > > --- > commit 5cfe81b7ddff9543d451746de9965cac58c67182 > Author: Michael Jeanson > Date: Wed Jul 27 10:44:00 2022 -0400 > > fix: sysconf(_SC_NPROCESSORS_CONF) can be less than max cpu id > > --- > > I started working around it, but it got a bit ugly. Is the change not > a Linuxism? Does it make sense on other systems? If QNX is the > exception then I can try to come up with a patch, but if not perhaps > the entire code should be wrapped by #ifdef __linux__? > > --Elad Hi, We'll need more details on the build failure you are seeing, there is already an '#ifdef __linux__' in 'src/compat-smp.h'. Can you send the relevant build errors? Michael _______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev