* babeltrace | sink.ctf.fs: add support to create LTTng index
@ 2025-12-01 9:34 MOESSBAUER, Felix via lttng-dev
2025-12-01 14:38 ` Philippe Proulx via lttng-dev
0 siblings, 1 reply; 3+ messages in thread
From: MOESSBAUER, Felix via lttng-dev @ 2025-12-01 9:34 UTC (permalink / raw)
To: lttng-dev
Hi,
I recently created a babeltrace pull request that adds support to
create an CTF LTTng index file along the CTF files [1].
It would be great, if someone could review it.
[1] https://github.com/efficios/babeltrace/pull/123
Best regards,
Felix Moessbauer
--
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: babeltrace | sink.ctf.fs: add support to create LTTng index
2025-12-01 9:34 babeltrace | sink.ctf.fs: add support to create LTTng index MOESSBAUER, Felix via lttng-dev
@ 2025-12-01 14:38 ` Philippe Proulx via lttng-dev
2025-12-03 9:58 ` MOESSBAUER, Felix via lttng-dev
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Proulx via lttng-dev @ 2025-12-01 14:38 UTC (permalink / raw)
To: MOESSBAUER, Felix; +Cc: lttng-dev
On Mon, Dec 1, 2025 at 4:34 AM MOESSBAUER, Felix via lttng-dev
<lttng-dev@lists.lttng.org> wrote:
>
> Hi,
>
> I recently created a babeltrace pull request that adds support to
> create an CTF LTTng index file along the CTF files [1].
>
> It would be great, if someone could review it.
Thank you for your pull requests.
I'll need to look at this in detail, but I'm not against the idea,
especially if it's guarded behind a no-by-default
initialization parameter.
That being said:
• We won't review on GitHub: please submit your change to our Gerrit
Code Review system (<https://review.lttng.org/>).
I know it's a bit more initial work on your side if you're not
familiar with Gerrit, but the review process will be much easier.
See <https://review.lttng.org/Documentation/user-upload.html> to learn
how to upload a change.
For this reason, I'll close the PRs immediately.
• You'll need to add a few tests to validate your feature.
• I'll deal with the documentation (manual pages) myself.
• Given our current workload before the end of the year, I'm not sure
I'll be able to review this before 2026.
Thank you for your contribution and for your patience with our
review process.
Philippe Proulx
EfficiOS
>
> [1] https://github.com/efficios/babeltrace/pull/123
>
> Best regards,
> Felix Moessbauer
>
> --
> Siemens AG
> Linux Expert Center
> Friedrich-Ludwig-Bauer-Str. 3
> 85748 Garching, Germany
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: babeltrace | sink.ctf.fs: add support to create LTTng index
2025-12-01 14:38 ` Philippe Proulx via lttng-dev
@ 2025-12-03 9:58 ` MOESSBAUER, Felix via lttng-dev
0 siblings, 0 replies; 3+ messages in thread
From: MOESSBAUER, Felix via lttng-dev @ 2025-12-03 9:58 UTC (permalink / raw)
To: eeppeliteloop; +Cc: lttng-dev
On Mon, 2025-12-01 at 09:38 -0500, Philippe Proulx wrote:
> On Mon, Dec 1, 2025 at 4:34 AM MOESSBAUER, Felix via lttng-dev
> <lttng-dev@lists.lttng.org> wrote:
> >
> > Hi,
> >
> > I recently created a babeltrace pull request that adds support to
> > create an CTF LTTng index file along the CTF files [1].
> >
> > It would be great, if someone could review it.
>
> Thank you for your pull requests.
>
> I'll need to look at this in detail, but I'm not against the idea,
> especially if it's guarded behind a no-by-default
> initialization parameter.
That's how I implemented it.
>
> That being said:
>
> • We won't review on GitHub: please submit your change to our Gerrit
> Code Review system (<https://review.lttng.org/>).
>
> I know it's a bit more initial work on your side if you're not
> familiar with Gerrit, but the review process will be much easier.
>
> See <https://review.lttng.org/Documentation/user-upload.html> to learn
> how to upload a change.
It would be great to add this note to the contributing guide as well.
>
> For this reason, I'll close the PRs immediately.
>
> • You'll need to add a few tests to validate your feature.
Sure. I will add them as I now known that the feature in general is
well received within the babeltrace project
>
> • I'll deal with the documentation (manual pages) myself.
Thanks!
>
> • Given our current workload before the end of the year, I'm not sure
> I'll be able to review this before 2026.
No problem. For me it would be great, if you could briefly comment if
the chosen interface is OK (boolean input parameter called "create-
lttng-index"). By that, I can continue the integration in bt2-ftrace-
to-ctf [1] and once the feature becomes officially available I don't
need to change the plugin again.
[1] https://github.com/siemens/bt2-ftrace-to-ctf/pull/13
Best regards,
Felix
--
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-03 9:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-01 9:34 babeltrace | sink.ctf.fs: add support to create LTTng index MOESSBAUER, Felix via lttng-dev
2025-12-01 14:38 ` Philippe Proulx via lttng-dev
2025-12-03 9:58 ` MOESSBAUER, Felix via lttng-dev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox