Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: Philippe Proulx via lttng-dev <lttng-dev@lists.lttng.org>
To: "MOESSBAUER, Felix" <felix.moessbauer@siemens.com>
Cc: "lttng-dev@lists.lttng.org" <lttng-dev@lists.lttng.org>
Subject: Re: babeltrace | sink.ctf.fs: add support to create LTTng index
Date: Mon, 1 Dec 2025 09:38:12 -0500	[thread overview]
Message-ID: <CAB4xu_0SBjk5xKXt_Q5gYWDC+iHg=oi08MyGyFhcBvvVmoAfvQ@mail.gmail.com> (raw)
In-Reply-To: <cd2f473df84132beca2d926819e15de514e10589.camel@siemens.com>

On Mon, Dec 1, 2025 at 4:34 AM MOESSBAUER, Felix via lttng-dev
<lttng-dev@lists.lttng.org> wrote:
>
> Hi,
>
> I recently created a babeltrace pull request that adds support to
> create an CTF LTTng index file along the CTF files [1].
>
> It would be great, if someone could review it.

Thank you for your pull requests.

I'll need to look at this in detail, but I'm not against the idea,
especially if it's guarded behind a no-by-default
initialization parameter.

That being said:

• We won't review on GitHub: please submit your change to our Gerrit
  Code Review system (<https://review.lttng.org/>).

  I know it's a bit more initial work on your side if you're not
  familiar with Gerrit, but the review process will be much easier.

  See <https://review.lttng.org/Documentation/user-upload.html> to learn
  how to upload a change.

  For this reason, I'll close the PRs immediately.

• You'll need to add a few tests to validate your feature.

• I'll deal with the documentation (manual pages) myself.

• Given our current workload before the end of the year, I'm not sure
  I'll be able to review this before 2026.

Thank you for your contribution and for your patience with our
review process.

Philippe Proulx
EfficiOS

>
> [1] https://github.com/efficios/babeltrace/pull/123
>
> Best regards,
> Felix Moessbauer
>
> --
> Siemens AG
> Linux Expert Center
> Friedrich-Ludwig-Bauer-Str. 3
> 85748 Garching, Germany
>

  reply	other threads:[~2025-12-01 14:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-01  9:34 MOESSBAUER, Felix via lttng-dev
2025-12-01 14:38 ` Philippe Proulx via lttng-dev [this message]
2025-12-03  9:58   ` MOESSBAUER, Felix via lttng-dev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB4xu_0SBjk5xKXt_Q5gYWDC+iHg=oi08MyGyFhcBvvVmoAfvQ@mail.gmail.com' \
    --to=lttng-dev@lists.lttng.org \
    --cc=eeppeliteloop@gmail.com \
    --cc=felix.moessbauer@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox