* [lttng-dev] [PATCH] Fix mm_vmscan_lru_isolate tracepoint for RHEL 9.4 kernel
@ 2024-05-17 14:30 Martin Hicks via lttng-dev
2024-05-17 16:04 ` Kienan Stewart via lttng-dev
0 siblings, 1 reply; 3+ messages in thread
From: Martin Hicks via lttng-dev @ 2024-05-17 14:30 UTC (permalink / raw)
To: lttng-dev
Redhat has moved to using the format first found in the 6.7 kernel
for the mm_vmscan_lru_isolate tracepoint.
Signed-off-by: Martin Hicks <martin@sr-research.com>
---
include/instrumentation/events/mm_vmscan.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/instrumentation/events/mm_vmscan.h b/include/instrumentation/events/mm_vmscan.h
index ea6f4b7..49a9eae 100644
--- a/include/instrumentation/events/mm_vmscan.h
+++ b/include/instrumentation/events/mm_vmscan.h
@@ -369,7 +369,9 @@ LTTNG_TRACEPOINT_EVENT_MAP(mm_shrink_slab_end,
)
#endif
-#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,7,0))
+#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,7,0) || \
+ LTTNG_RHEL_KERNEL_RANGE(5,14,0,427,0,0, 5,15,0,0,0,0))
+
LTTNG_TRACEPOINT_EVENT(mm_vmscan_lru_isolate,
TP_PROTO(int classzone_idx,
--
2.43.0
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lttng-dev] [PATCH] Fix mm_vmscan_lru_isolate tracepoint for RHEL 9.4 kernel
2024-05-17 14:30 [lttng-dev] [PATCH] Fix mm_vmscan_lru_isolate tracepoint for RHEL 9.4 kernel Martin Hicks via lttng-dev
@ 2024-05-17 16:04 ` Kienan Stewart via lttng-dev
2024-05-22 20:09 ` Mathieu Desnoyers via lttng-dev
0 siblings, 1 reply; 3+ messages in thread
From: Kienan Stewart via lttng-dev @ 2024-05-17 16:04 UTC (permalink / raw)
To: Martin Hicks, lttng-dev
Hi Martin,
thanks for the patch.
I changed the version range slightly. The RHEL kernel 5.14.0-427.13.1
still has the `isolate_mode` parameter in the `mm_vmscan_lru_isolate`
tracepoint; it was only removed in 5.14.0-427.16.1.
I also forward ported the patch to the master branch.
The updated patches will be reviewed at:
https://review.lttng.org/q/topic:%22buildfix-el9.4%22
thanks,
kienan
On 5/17/24 10:30 AM, Martin Hicks via lttng-dev wrote:
>
>
> Redhat has moved to using the format first found in the 6.7 kernel
> for the mm_vmscan_lru_isolate tracepoint.
>
> Signed-off-by: Martin Hicks <martin@sr-research.com>
> ---
> include/instrumentation/events/mm_vmscan.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/instrumentation/events/mm_vmscan.h b/include/instrumentation/events/mm_vmscan.h
> index ea6f4b7..49a9eae 100644
> --- a/include/instrumentation/events/mm_vmscan.h
> +++ b/include/instrumentation/events/mm_vmscan.h
> @@ -369,7 +369,9 @@ LTTNG_TRACEPOINT_EVENT_MAP(mm_shrink_slab_end,
> )
> #endif
>
> -#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,7,0))
> +#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,7,0) || \
> + LTTNG_RHEL_KERNEL_RANGE(5,14,0,427,0,0, 5,15,0,0,0,0))
> +
> LTTNG_TRACEPOINT_EVENT(mm_vmscan_lru_isolate,
>
> TP_PROTO(int classzone_idx,
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lttng-dev] [PATCH] Fix mm_vmscan_lru_isolate tracepoint for RHEL 9.4 kernel
2024-05-17 16:04 ` Kienan Stewart via lttng-dev
@ 2024-05-22 20:09 ` Mathieu Desnoyers via lttng-dev
0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Desnoyers via lttng-dev @ 2024-05-22 20:09 UTC (permalink / raw)
To: Kienan Stewart, Martin Hicks, lttng-dev
On 2024-05-17 12:04, Kienan Stewart via lttng-dev wrote:
> Hi Martin,
>
> thanks for the patch.
>
> I changed the version range slightly. The RHEL kernel 5.14.0-427.13.1
> still has the `isolate_mode` parameter in the `mm_vmscan_lru_isolate`
> tracepoint; it was only removed in 5.14.0-427.16.1.
>
> I also forward ported the patch to the master branch.
>
> The updated patches will be reviewed at:
> https://review.lttng.org/q/topic:%22buildfix-el9.4%22
Merged into lttng-modules master and stable-2.13, thanks!
Mathieu
>
> thanks,
> kienan
>
> On 5/17/24 10:30 AM, Martin Hicks via lttng-dev wrote:
>>
>>
>> Redhat has moved to using the format first found in the 6.7 kernel
>> for the mm_vmscan_lru_isolate tracepoint.
>>
>> Signed-off-by: Martin Hicks <martin@sr-research.com>
>> ---
>> include/instrumentation/events/mm_vmscan.h | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/instrumentation/events/mm_vmscan.h
>> b/include/instrumentation/events/mm_vmscan.h
>> index ea6f4b7..49a9eae 100644
>> --- a/include/instrumentation/events/mm_vmscan.h
>> +++ b/include/instrumentation/events/mm_vmscan.h
>> @@ -369,7 +369,9 @@ LTTNG_TRACEPOINT_EVENT_MAP(mm_shrink_slab_end,
>> )
>> #endif
>> -#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,7,0))
>> +#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,7,0) || \
>> + LTTNG_RHEL_KERNEL_RANGE(5,14,0,427,0,0, 5,15,0,0,0,0))
>> +
>> LTTNG_TRACEPOINT_EVENT(mm_vmscan_lru_isolate,
>> TP_PROTO(int classzone_idx,
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-22 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-17 14:30 [lttng-dev] [PATCH] Fix mm_vmscan_lru_isolate tracepoint for RHEL 9.4 kernel Martin Hicks via lttng-dev
2024-05-17 16:04 ` Kienan Stewart via lttng-dev
2024-05-22 20:09 ` Mathieu Desnoyers via lttng-dev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox