Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: Kienan Stewart via lttng-dev <lttng-dev@lists.lttng.org>
To: Martin Hicks <martin@sr-research.com>, lttng-dev@lists.lttng.org
Subject: Re: [lttng-dev] [PATCH] Fix mm_vmscan_lru_isolate tracepoint for RHEL 9.4 kernel
Date: Fri, 17 May 2024 12:04:18 -0400	[thread overview]
Message-ID: <9e00bf4e-1059-402b-9be2-ef407dbdf039@efficios.com> (raw)
In-Reply-To: <ZkdnIf/OX995MndN@t14.bork.org>

Hi Martin,

thanks for the patch.

I changed the version range slightly. The RHEL kernel 5.14.0-427.13.1 
still has the `isolate_mode` parameter in the `mm_vmscan_lru_isolate` 
tracepoint; it was only removed in 5.14.0-427.16.1.

I also forward ported the patch to the master branch.

The updated patches will be reviewed at: 
https://review.lttng.org/q/topic:%22buildfix-el9.4%22

thanks,
kienan

On 5/17/24 10:30 AM, Martin Hicks via lttng-dev wrote:
> 
> 
> Redhat has moved to using the format first found in the 6.7 kernel
> for the mm_vmscan_lru_isolate tracepoint.
> 
> Signed-off-by: Martin Hicks <martin@sr-research.com>
> ---
>   include/instrumentation/events/mm_vmscan.h | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/instrumentation/events/mm_vmscan.h b/include/instrumentation/events/mm_vmscan.h
> index ea6f4b7..49a9eae 100644
> --- a/include/instrumentation/events/mm_vmscan.h
> +++ b/include/instrumentation/events/mm_vmscan.h
> @@ -369,7 +369,9 @@ LTTNG_TRACEPOINT_EVENT_MAP(mm_shrink_slab_end,
>   )
>   #endif
>   
> -#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,7,0))
> +#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,7,0) || \
> +     LTTNG_RHEL_KERNEL_RANGE(5,14,0,427,0,0, 5,15,0,0,0,0))
> +
>   LTTNG_TRACEPOINT_EVENT(mm_vmscan_lru_isolate,
>   
>   	TP_PROTO(int classzone_idx,
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

  reply	other threads:[~2024-05-17 16:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17 14:30 Martin Hicks via lttng-dev
2024-05-17 16:04 ` Kienan Stewart via lttng-dev [this message]
2024-05-22 20:09   ` Mathieu Desnoyers via lttng-dev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e00bf4e-1059-402b-9be2-ef407dbdf039@efficios.com \
    --to=lttng-dev@lists.lttng.org \
    --cc=kstewart@efficios.com \
    --cc=martin@sr-research.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox