* [ltt-dev] [UST PATCH] Make the error handling in open_channel more readable
@ 2011-02-21 16:55 Yannick Brosseau
2011-02-23 4:06 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP9165A2945ADE5682920AC096DB0@phx.gbl>
0 siblings, 2 replies; 4+ messages in thread
From: Yannick Brosseau @ 2011-02-21 16:55 UTC (permalink / raw)
Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
---
libust/buffers.c | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/libust/buffers.c b/libust/buffers.c
index 4e8004c..534d0ef 100644
--- a/libust/buffers.c
+++ b/libust/buffers.c
@@ -319,12 +319,11 @@ static int open_channel(struct ust_channel *chan, size_t subbuf_size,
return 0;
- /* Jump directly inside the loop to close the buffers that were already
- * opened. */
- for(; i>=0; i--) {
- close_buf(chan->buf[i]);
error:
- do {} while(0);
+ /* Loop through the opened buffers and close them. Skip the current i,
+ since it's the one that did not open. */
+ for(i--; i>=0; i--) {
+ close_buf(chan->buf[i]);
}
pthread_mutex_unlock(&ust_buffers_channels_mutex);
--
1.7.2.3
^ permalink raw reply [flat|nested] 4+ messages in thread* [ltt-dev] [UST PATCH] Make the error handling in open_channel more readable
2011-02-21 16:55 [ltt-dev] [UST PATCH] Make the error handling in open_channel more readable Yannick Brosseau
@ 2011-02-23 4:06 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP9165A2945ADE5682920AC096DB0@phx.gbl>
1 sibling, 0 replies; 4+ messages in thread
From: Mathieu Desnoyers @ 2011-02-23 4:06 UTC (permalink / raw)
* Yannick Brosseau (yannick.brosseau at gmail.com) wrote:
> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
> ---
> libust/buffers.c | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/libust/buffers.c b/libust/buffers.c
> index 4e8004c..534d0ef 100644
> --- a/libust/buffers.c
> +++ b/libust/buffers.c
> @@ -319,12 +319,11 @@ static int open_channel(struct ust_channel *chan, size_t subbuf_size,
>
> return 0;
>
> - /* Jump directly inside the loop to close the buffers that were already
> - * opened. */
> - for(; i>=0; i--) {
> - close_buf(chan->buf[i]);
> error:
> - do {} while(0);
> + /* Loop through the opened buffers and close them. Skip the current i,
> + since it's the one that did not open. */
> + for(i--; i>=0; i--) {
> + close_buf(chan->buf[i]);
Not sure I see how this is more readable. You seem to be changing the
code behavior too.
Mathieu
> }
>
> pthread_mutex_unlock(&ust_buffers_channels_mutex);
> --
> 1.7.2.3
>
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <BLU0-SMTP9165A2945ADE5682920AC096DB0@phx.gbl>]
* [ltt-dev] [UST PATCH] Make the error handling in open_channel more readable
[not found] ` <BLU0-SMTP9165A2945ADE5682920AC096DB0@phx.gbl>
@ 2011-02-23 4:13 ` Yannick Brosseau
2011-02-23 4:23 ` Mathieu Desnoyers
0 siblings, 1 reply; 4+ messages in thread
From: Yannick Brosseau @ 2011-02-23 4:13 UTC (permalink / raw)
On 2011-02-22 23:06, Mathieu Desnoyers wrote:
> * Yannick Brosseau (yannick.brosseau at gmail.com) wrote:
>
>> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
>> ---
>> libust/buffers.c | 9 ++++-----
>> 1 files changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/libust/buffers.c b/libust/buffers.c
>> index 4e8004c..534d0ef 100644
>> --- a/libust/buffers.c
>> +++ b/libust/buffers.c
>> @@ -319,12 +319,11 @@ static int open_channel(struct ust_channel *chan, size_t subbuf_size,
>>
>> return 0;
>>
>> - /* Jump directly inside the loop to close the buffers that were already
>> - * opened. */
>> - for(; i>=0; i--) {
>> - close_buf(chan->buf[i]);
>> error:
>> - do {} while(0);
>> + /* Loop through the opened buffers and close them. Skip the current i,
>> + since it's the one that did not open. */
>> + for(i--; i>=0; i--) {
>> + close_buf(chan->buf[i]);
>>
> Not sure I see how this is more readable. You seem to be changing the
> code behavior too.
>
At least we don't have a jump un the middle of a loop and a complex nop
operation.
The behavior is the same.
We could also not reuse the i and loop from 0 to i-1.
^ permalink raw reply [flat|nested] 4+ messages in thread* [ltt-dev] [UST PATCH] Make the error handling in open_channel more readable
2011-02-23 4:13 ` Yannick Brosseau
@ 2011-02-23 4:23 ` Mathieu Desnoyers
0 siblings, 0 replies; 4+ messages in thread
From: Mathieu Desnoyers @ 2011-02-23 4:23 UTC (permalink / raw)
* Yannick Brosseau (yannick.brosseau at gmail.com) wrote:
> On 2011-02-22 23:06, Mathieu Desnoyers wrote:
> > * Yannick Brosseau (yannick.brosseau at gmail.com) wrote:
> >
> >> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
> >> ---
> >> libust/buffers.c | 9 ++++-----
> >> 1 files changed, 4 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/libust/buffers.c b/libust/buffers.c
> >> index 4e8004c..534d0ef 100644
> >> --- a/libust/buffers.c
> >> +++ b/libust/buffers.c
> >> @@ -319,12 +319,11 @@ static int open_channel(struct ust_channel *chan, size_t subbuf_size,
> >>
> >> return 0;
> >>
> >> - /* Jump directly inside the loop to close the buffers that were already
> >> - * opened. */
> >> - for(; i>=0; i--) {
> >> - close_buf(chan->buf[i]);
> >> error:
> >> - do {} while(0);
> >> + /* Loop through the opened buffers and close them. Skip the current i,
> >> + since it's the one that did not open. */
> >> + for(i--; i>=0; i--) {
> >> + close_buf(chan->buf[i]);
> >>
> > Not sure I see how this is more readable. You seem to be changing the
> > code behavior too.
> >
>
> At least we don't have a jump un the middle of a loop and a complex nop
> operation.
> The behavior is the same.
>
> We could also not reuse the i and loop from 0 to i-1.
>
OK, I did coding style updates, but the change has been committed.
Thanks,
Mathieu
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-23 4:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-21 16:55 [ltt-dev] [UST PATCH] Make the error handling in open_channel more readable Yannick Brosseau
2011-02-23 4:06 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP9165A2945ADE5682920AC096DB0@phx.gbl>
2011-02-23 4:13 ` Yannick Brosseau
2011-02-23 4:23 ` Mathieu Desnoyers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox