Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
Subject: [lttng-dev] LTTng wrapper cleanup
Date: Wed, 30 Nov 2011 10:47:17 -0800	[thread overview]
Message-ID: <20111130184717.GC26452@kroah.com> (raw)
In-Reply-To: <1322678068-5255-1-git-send-email-mathieu.desnoyers@efficios.com>

On Wed, Nov 30, 2011 at 01:34:13PM -0500, Mathieu Desnoyers wrote:
> 
> Hi Greg,
> 
> Here is the cleanup of the LTTng wrappers that used kallsyms to lookup
> some kernel symbols. I introduce the missing symbols in the mainline
> kernel, trying to follow the local exports already in place when it
> comes to choosing between EXPORT_SYMBOL and EXPORT_SYMBOL_GPL. I also
> removed wrappers that deal with API changes across kernel versions (for
> older kernels). Only few wrapper files are left at this point (TODO),
> but those are less repulsive than those that used kallsyms:
> 
> - inline_memcpy.h: ensures that inline_memcpy is declared on all
>   architectures.
> - poll.h: see TODO file, "Features" section.
> - trace-clock.h: see TODO file, "Features" section.
> - ringbuffer: those are internal to the driver. They were there to make
>   it easier to switch between the ringbuffer deployed in my own kernel
>   tree and the module-specific ringbuffer.
> 
> The 3 first patches are small cleanups recommended to me by a static
> checker.
> 
> Diffstat:
> 
>  b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_frontend.c |    6 
>  b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c     |    3 
>  drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c       |    3 

Hm, try 'diffstat -p1' next time please, for a cleaner "real" version of
what is going on here.

greg k-h



  parent reply	other threads:[~2011-11-30 18:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 18:34 Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 01/15] lttng lib: ring buffer: remove stale null-pointer Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 02/15] lttng lib: ring buffer remove duplicate null pointer Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 03/15] lttng lib: ring buffer move null pointer check to open Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 04/15] Export vmalloc_sync_all symbol to GPL modules Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 05/15] lttng wrapper: add missing include to kallsyms wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 06/15] Remove LTTng vmalloc_sync_all wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 07/15] fs/splice: export splice_to_pipe to modules Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 08/15] lttng: remove splice_to_pipe wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 09/15] lttng: remove perf_event_create_kernel_counter wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 10/15] lttng: remove ftrace function tracer support (but keep Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 11/15] lttng: remove raw spinlock wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 12/15] lttng: remove uuid wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 13/15] Export task_prio to modules Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 14/15] lttng: remove task_prio wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 15/15] lttng: remove kallsyms wrapper Mathieu Desnoyers
2011-11-30 18:47 ` Greg KH [this message]
2011-11-30 19:13   ` [lttng-dev] LTTng wrapper cleanup Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111130184717.GC26452@kroah.com \
    --to=greg@kroah.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox