From mboxrd@z Thu Jan 1 00:00:00 1970 From: greg@kroah.com (Greg KH) Date: Wed, 30 Nov 2011 10:47:17 -0800 Subject: [lttng-dev] LTTng wrapper cleanup In-Reply-To: <1322678068-5255-1-git-send-email-mathieu.desnoyers@efficios.com> References: <1322678068-5255-1-git-send-email-mathieu.desnoyers@efficios.com> Message-ID: <20111130184717.GC26452@kroah.com> On Wed, Nov 30, 2011 at 01:34:13PM -0500, Mathieu Desnoyers wrote: > > Hi Greg, > > Here is the cleanup of the LTTng wrappers that used kallsyms to lookup > some kernel symbols. I introduce the missing symbols in the mainline > kernel, trying to follow the local exports already in place when it > comes to choosing between EXPORT_SYMBOL and EXPORT_SYMBOL_GPL. I also > removed wrappers that deal with API changes across kernel versions (for > older kernels). Only few wrapper files are left at this point (TODO), > but those are less repulsive than those that used kallsyms: > > - inline_memcpy.h: ensures that inline_memcpy is declared on all > architectures. > - poll.h: see TODO file, "Features" section. > - trace-clock.h: see TODO file, "Features" section. > - ringbuffer: those are internal to the driver. They were there to make > it easier to switch between the ringbuffer deployed in my own kernel > tree and the module-specific ringbuffer. > > The 3 first patches are small cleanups recommended to me by a static > checker. > > Diffstat: > > b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_frontend.c | 6 > b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c | 3 > drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c | 3 Hm, try 'diffstat -p1' next time please, for a cleaner "real" version of what is going on here. greg k-h