From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers)
Subject: [lttng-dev] LTTng wrapper cleanup
Date: Wed, 30 Nov 2011 13:34:13 -0500 [thread overview]
Message-ID: <1322678068-5255-1-git-send-email-mathieu.desnoyers@efficios.com> (raw)
Hi Greg,
Here is the cleanup of the LTTng wrappers that used kallsyms to lookup
some kernel symbols. I introduce the missing symbols in the mainline
kernel, trying to follow the local exports already in place when it
comes to choosing between EXPORT_SYMBOL and EXPORT_SYMBOL_GPL. I also
removed wrappers that deal with API changes across kernel versions (for
older kernels). Only few wrapper files are left at this point (TODO),
but those are less repulsive than those that used kallsyms:
- inline_memcpy.h: ensures that inline_memcpy is declared on all
architectures.
- poll.h: see TODO file, "Features" section.
- trace-clock.h: see TODO file, "Features" section.
- ringbuffer: those are internal to the driver. They were there to make
it easier to switch between the ringbuffer deployed in my own kernel
tree and the module-specific ringbuffer.
The 3 first patches are small cleanups recommended to me by a static
checker.
Diffstat:
b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_frontend.c | 6
b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c | 3
drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c | 3
b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_vfs.c | 3
b/mm/nommu.c | 1
b/mm/vmalloc.c | 1
b/drivers/staging/lttng/wrapper/kallsyms.h | 2
b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_backend.c | 3
b/drivers/staging/lttng/ltt-context.c | 1
b/drivers/staging/lttng/ltt-debugfs-abi.c | 3
b/drivers/staging/lttng/ltt-events.c | 3
b/drivers/staging/lttng/ltt-ring-buffer-client.h | 3
b/drivers/staging/lttng/ltt-ring-buffer-metadata-client.h | 3
b/drivers/staging/lttng/lttng-context-nice.c | 3
b/drivers/staging/lttng/lttng-context-perf-counters.c | 3
b/drivers/staging/lttng/lttng-context-pid.c | 3
b/drivers/staging/lttng/lttng-context-ppid.c | 3
b/drivers/staging/lttng/lttng-context-prio.c | 3
b/drivers/staging/lttng/lttng-context-procname.c | 3
b/drivers/staging/lttng/lttng-context-tid.c | 3
b/drivers/staging/lttng/lttng-context-vpid.c | 3
b/drivers/staging/lttng/lttng-context-vppid.c | 3
b/drivers/staging/lttng/lttng-context-vtid.c | 3
b/drivers/staging/lttng/lttng-syscalls.c | 2
b/drivers/staging/lttng/probes/lttng-events.h | 3
b/drivers/staging/lttng/probes/lttng-ftrace.c | 5
b/drivers/staging/lttng/probes/lttng-kprobes.c | 3
b/drivers/staging/lttng/probes/lttng-kretprobes.c | 3
b/drivers/staging/lttng/probes/lttng-types.c | 3
drivers/staging/lttng/wrapper/vmalloc.h | 49 --
b/fs/splice.c | 1
b/drivers/staging/lttng/lib/Makefile | 3
b/drivers/staging/lttng/lib/ringbuffer/ring_buffer_splice.c | 3
drivers/staging/lttng/wrapper/splice.c | 46 --
drivers/staging/lttng/wrapper/splice.h | 23 -
drivers/staging/lttng/lttng-context-perf-counters.c | 9
drivers/staging/lttng/wrapper/perf.h | 32 -
b/drivers/staging/lttng/README | 4
drivers/staging/lttng/ltt-events.c | 11
b/drivers/staging/lttng/probes/Makefile | 4
a/drivers/staging/lttng/probes/lttng-ftrace.c | 187 ----------
drivers/staging/lttng/wrapper/ftrace.h | 70 ---
b/drivers/staging/lttng/lib/ringbuffer/frontend_types.h | 1
drivers/staging/lttng/wrapper/spinlock.h | 26 -
b/drivers/staging/lttng/ltt-events.h | 3
drivers/staging/lttng/wrapper/uuid.h | 29 -
b/kernel/sched.c | 1
drivers/staging/lttng/lttng-context-prio.c | 23 -
a/drivers/staging/lttng/wrapper/kallsyms.h | 30 -
49 files changed, 44 insertions(+), 595 deletions(-)
Thanks,
Mathieu
next reply other threads:[~2011-11-30 18:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 18:34 Mathieu Desnoyers [this message]
2011-11-30 18:34 ` [lttng-dev] [PATCH 01/15] lttng lib: ring buffer: remove stale null-pointer Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 02/15] lttng lib: ring buffer remove duplicate null pointer Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 03/15] lttng lib: ring buffer move null pointer check to open Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 04/15] Export vmalloc_sync_all symbol to GPL modules Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 05/15] lttng wrapper: add missing include to kallsyms wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 06/15] Remove LTTng vmalloc_sync_all wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 07/15] fs/splice: export splice_to_pipe to modules Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 08/15] lttng: remove splice_to_pipe wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 09/15] lttng: remove perf_event_create_kernel_counter wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 10/15] lttng: remove ftrace function tracer support (but keep Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 11/15] lttng: remove raw spinlock wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 12/15] lttng: remove uuid wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 13/15] Export task_prio to modules Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 14/15] lttng: remove task_prio wrapper Mathieu Desnoyers
2011-11-30 18:34 ` [lttng-dev] [PATCH 15/15] lttng: remove kallsyms wrapper Mathieu Desnoyers
2011-11-30 18:47 ` [lttng-dev] LTTng wrapper cleanup Greg KH
2011-11-30 19:13 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322678068-5255-1-git-send-email-mathieu.desnoyers@efficios.com \
--to=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox