From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Subject: [ltt-dev] [PATCH take2 01/13] make marker_entry permanent
Date: Mon, 2 Mar 2009 20:14:52 -0500 [thread overview]
Message-ID: <20090303011452.GA7566@Krystal> (raw)
In-Reply-To: <49AC7FAB.3000407@cn.fujitsu.com>
* Lai Jiangshan (laijs at cn.fujitsu.com) wrote:
> Mathieu Desnoyers ??:
> >>
> >> +int ltt_channel_alive(const char *channel)
> >> +{
> >> + int ret;
> >> + mutex_lock(<t_channel_mutex);
> >> + ret = !!atomic_read(&index_kref.refcount);
> >> + mutex_unlock(<t_channel_mutex);
> >
> > Why are you taking the ltt_channel_mutex to read a variable atomically ?
> > There is probably something you intend to protect (race between stopping
> > to use a channel and removing a marker), but I am pretty much sure this
> > locking does not do what you intend.
> >
> > Mathieu
> >
> >> + return ret;
> >> +}
> >> +
>
>
> Hi, Mathieu,
>
> You can feel free to fix patches(comments, changelog, code) and
> merge them.
>
OK. By the way, thanks for doing all this work, this saves me a lot of
time. I'll take care of the last mile and get the patches in shape to
merge them into LTTng.
Mathieu
> Lai.
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
prev parent reply other threads:[~2009-03-03 1:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 3:31 Lai Jiangshan
2009-02-23 16:34 ` Mathieu Desnoyers
2009-03-03 0:54 ` Lai Jiangshan
2009-03-03 1:14 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090303011452.GA7566@Krystal \
--to=compudj@krystal.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox