From mboxrd@z Thu Jan  1 00:00:00 1970
From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Date: Mon, 2 Mar 2009 20:14:52 -0500
Subject: [ltt-dev] [PATCH take2 01/13] make marker_entry permanent
In-Reply-To: <49AC7FAB.3000407@cn.fujitsu.com>
References: <498A5D79.8010701@cn.fujitsu.com> <20090223163425.GA31815@Krystal>
	<49AC7FAB.3000407@cn.fujitsu.com>
Message-ID: <20090303011452.GA7566@Krystal>

* Lai Jiangshan (laijs at cn.fujitsu.com) wrote:
> Mathieu Desnoyers ??:
> >>  
> >> +int ltt_channel_alive(const char *channel)
> >> +{
> >> +	int ret;
> >> +	mutex_lock(&ltt_channel_mutex);
> >> +	ret = !!atomic_read(&index_kref.refcount);
> >> +	mutex_unlock(&ltt_channel_mutex);
> > 
> > Why are you taking the ltt_channel_mutex to read a variable atomically ?
> > There is probably something you intend to protect (race between stopping
> > to use a channel and removing a marker), but I am pretty much sure this
> > locking does not do what you intend.
> > 
> > Mathieu
> > 
> >> +	return ret;
> >> +}
> >> +
> 
> 
> Hi, Mathieu,
> 
> You can feel free to fix patches(comments, changelog, code) and
> merge them.
> 

OK. By the way, thanks for doing all this work, this saves me a lot of
time. I'll take care of the last mile and get the patches in shape to
merge them into LTTng.

Mathieu

> Lai.
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68