From: laijs@cn.fujitsu.com (Lai Jiangshan)
Subject: [ltt-dev] [PATCH take2 01/13] make marker_entry permanent
Date: Tue, 03 Mar 2009 08:54:03 +0800 [thread overview]
Message-ID: <49AC7FAB.3000407@cn.fujitsu.com> (raw)
In-Reply-To: <20090223163425.GA31815@Krystal>
Mathieu Desnoyers ??:
>>
>> +int ltt_channel_alive(const char *channel)
>> +{
>> + int ret;
>> + mutex_lock(<t_channel_mutex);
>> + ret = !!atomic_read(&index_kref.refcount);
>> + mutex_unlock(<t_channel_mutex);
>
> Why are you taking the ltt_channel_mutex to read a variable atomically ?
> There is probably something you intend to protect (race between stopping
> to use a channel and removing a marker), but I am pretty much sure this
> locking does not do what you intend.
>
> Mathieu
>
>> + return ret;
>> +}
>> +
Hi, Mathieu,
You can feel free to fix patches(comments, changelog, code) and
merge them.
Lai.
next prev parent reply other threads:[~2009-03-03 0:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 3:31 Lai Jiangshan
2009-02-23 16:34 ` Mathieu Desnoyers
2009-03-03 0:54 ` Lai Jiangshan [this message]
2009-03-03 1:14 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AC7FAB.3000407@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox