Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: kosaki.motohiro@jp.fujitsu.com (KOSAKI Motohiro)
Subject: [ltt-dev] [patch 4/7] omap lttng use iter div
Date: Thu, 19 Feb 2009 09:29:44 +0900 (JST)	[thread overview]
Message-ID: <20090219092852.9553.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20090218075132.874024744@polymtl.ca>

> ARM does no seem to like u64 div in math64.h. Use the "iter" version.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at polymtl.ca>
> ---
>  kernel/trace/trace-clock-32-to-64.c |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> Index: linux-omap-2.6/kernel/trace/trace-clock-32-to-64.c
> ===================================================================
> --- linux-omap-2.6.orig/kernel/trace/trace-clock-32-to-64.c	2009-02-16 00:39:18.000000000 +0000
> +++ linux-omap-2.6/kernel/trace/trace-clock-32-to-64.c	2009-02-16 00:41:42.000000000 +0000
> @@ -153,13 +153,15 @@
>   */
>  static int __init precalc_stsc_interval(void)
>  {
> +	u64 rem_freq, rem_interval;
> +
>  	precalc_expire =
> -		div_u64(HW_BITMASK,
> -		 ((div_u64(trace_clock_frequency(), HZ)
> +		__iter_div_u64_rem(HW_BITMASK,
> +		 ((__iter_div_u64_rem(trace_clock_frequency(), HZ, &rem_freq)
>  		     * trace_clock_freq_scale())
>  		    << 1)
>  		 - 1
> -		 - (EXPECTED_INTERRUPT_LATENCY * HZ / 1000))
> +		 - (EXPECTED_INTERRUPT_LATENCY * HZ / 1000), &rem_interval)
>  		>> 1;
>  	WARN_ON(precalc_expire == 0);
>  	printk(KERN_DEBUG "Synthetic TSC timer will fire each %u jiffies.\n",

Instead, implement div_u64() for arm is bad idea?







  reply	other threads:[~2009-02-19  0:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18  7:47 [ltt-dev] [patch 0/7] LTTng for ARM OMAP3 Mathieu Desnoyers
2009-02-18  7:47 ` [ltt-dev] [patch 1/7] omap lttng instrumentation kernel fix Mathieu Desnoyers
2009-02-18  7:47 ` [ltt-dev] [patch 2/7] LTTng - ARM instrumentation Mathieu Desnoyers
2009-02-18  7:47 ` [ltt-dev] [patch 3/7] OMAP ltt statedump include irq.h Mathieu Desnoyers
2009-02-19  0:23   ` KOSAKI Motohiro
2009-02-19  3:10     ` Mathieu Desnoyers
2009-02-20  1:39       ` KOSAKI Motohiro
2009-02-18  7:47 ` [ltt-dev] [patch 4/7] omap lttng use iter div Mathieu Desnoyers
2009-02-19  0:29   ` KOSAKI Motohiro [this message]
2009-02-19  3:13     ` Mathieu Desnoyers
2009-02-18  7:47 ` [ltt-dev] [patch 5/7] omap lttng statedump arm Mathieu Desnoyers
2009-02-18  7:47 ` [ltt-dev] [patch 6/7] omap trace clock specialize Mathieu Desnoyers
2009-02-18  7:47 ` [ltt-dev] [patch 7/7] omap trace clock Mathieu Desnoyers
2009-02-18 16:58   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090219092852.9553.A69D9226@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox