[ltt-dev] [patch 4/7] omap lttng use iter div

[compudj@krystal.dyndns.org (Mathieu Desnoyers)]

* KOSAKI Motohiro (kosaki.motohiro at jp.fujitsu.com) wrote:
> > ARM does no seem to like u64 div in math64.h. Use the "iter" version.
> > 
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at polymtl.ca>
> > ---
> >  kernel/trace/trace-clock-32-to-64.c |    8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > Index: linux-omap-2.6/kernel/trace/trace-clock-32-to-64.c
> > ===================================================================
> > --- linux-omap-2.6.orig/kernel/trace/trace-clock-32-to-64.c	2009-02-16 00:39:18.000000000 +0000
> > +++ linux-omap-2.6/kernel/trace/trace-clock-32-to-64.c	2009-02-16 00:41:42.000000000 +0000
> > @@ -153,13 +153,15 @@
> >   */
> >  static int __init precalc_stsc_interval(void)
> >  {
> > +	u64 rem_freq, rem_interval;
> > +
> >  	precalc_expire =
> > -		div_u64(HW_BITMASK,
> > -		 ((div_u64(trace_clock_frequency(), HZ)
> > +		__iter_div_u64_rem(HW_BITMASK,
> > +		 ((__iter_div_u64_rem(trace_clock_frequency(), HZ, &rem_freq)
> >  		     * trace_clock_freq_scale())
> >  		    << 1)
> >  		 - 1
> > -		 - (EXPECTED_INTERRUPT_LATENCY * HZ / 1000))
> > +		 - (EXPECTED_INTERRUPT_LATENCY * HZ / 1000), &rem_interval)
> >  		>> 1;
> >  	WARN_ON(precalc_expire == 0);
> >  	printk(KERN_DEBUG "Synthetic TSC timer will fire each %u jiffies.\n",
> 
> Instead, implement div_u64() for arm is bad idea?
> 
> 

This is indeed a very good idea ! Is anyone willing to do it ?

Mathieu

> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68