From: kosaki.motohiro@jp.fujitsu.com (KOSAKI Motohiro)
Subject: [ltt-dev] [PATCH v2] lttng: remove ltt root directory if it's no needed
Date: Thu, 19 Feb 2009 08:50:49 +0900 (JST) [thread overview]
Message-ID: <20090219084728.9547.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <499BF60B.7090603@cn.fujitsu.com>
Hi
> We have to cleanup the lttng's root directory of debugfs if
> there is nobody uses it any more.
Why "have to"?
This description don't explain anything.
diff --git a/ltt/ltt-trace-control.c b/ltt/ltt-trace-control.c
> index 16502a2..0cdeb8a 100644
> --- a/ltt/ltt-trace-control.c
> +++ b/ltt/ltt-trace-control.c
> @@ -740,7 +740,8 @@ err_create_destroy_trace_file:
> err_create_setup_trace_file:
> debugfs_remove(ltt_control_dir);
> err_create_control_dir:
> -err_no_root:
> + put_ltt_root();
> + err_no_root:
label indentation is considered bad conding style in lkml.
next prev parent reply other threads:[~2009-02-18 23:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 8:16 [ltt-dev] [PATCH] " Gui Jianfeng
2009-02-18 8:28 ` Mathieu Desnoyers
2009-02-18 9:00 ` Gui Jianfeng
2009-02-18 11:50 ` [ltt-dev] [PATCH v2] " Gui Jianfeng
2009-02-18 23:50 ` KOSAKI Motohiro [this message]
2009-02-19 1:16 ` Gui Jianfeng
2009-02-19 1:39 ` [ltt-dev] [PATCH v3] " Gui Jianfeng
2009-02-19 2:02 ` KOSAKI Motohiro
2009-02-19 2:19 ` Gui Jianfeng
2009-02-19 2:38 ` Mathieu Desnoyers
2009-02-19 3:14 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219084728.9547.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox