[ltt-dev] [PATCH v3] lttng: remove ltt root directory if it's no needed

[guijianfeng@cn.fujitsu.com (Gui Jianfeng)]

KOSAKI Motohiro wrote:
>> We have to cleanup the lttng's root directory of debugfs if 
>> there is nobody uses it any more. Because any related lttng
>> modules are unloaded, no need to keep this directory.
>>
>> This patch is based on 2.6.29-rc3-lttng-0.92.
> 
> hmhm. There is one meta question.
> 
> Why do we need ltt-control unloadability?
> We expect merge lttng into mainline in nearly future.
> 
> At that time, Who need ltt core kernel module (not any specific probe).
> 
> IOW, why ca't we do following?
> 
> 
> config LTT_TRACE_CONTROL
> -        tristate "Linux Trace Toolkit Trace Controller"
> +        bool "Linux Trace Toolkit Trace Controller"
>         depends on LTT_TRACER
>         default m
>         help
>           If you enable this option, the debugfs-based Linux Trace Toolkit Trace
>           Controller will be either built in the kernel or as module.

  That sounds reasonalbe. :)
  I guess this mainly because there are multiple ways to do ltt controling.
  We can do it through debugfs interface, also the netlink interface is still
  available. But I think the netlink interface is not needed anymore by now, 
  can be removed...

> 
> 
> 
> 
> 
> 

-- 
Regards
Gui Jianfeng