From mboxrd@z Thu Jan  1 00:00:00 1970
From: kosaki.motohiro@jp.fujitsu.com (KOSAKI Motohiro)
Date: Thu, 19 Feb 2009 08:50:49 +0900 (JST)
Subject: [ltt-dev] [PATCH v2] lttng: remove ltt root directory if it's
	no needed
In-Reply-To: <499BF60B.7090603@cn.fujitsu.com>
References: <20090218082858.GB6658@Krystal> <499BF60B.7090603@cn.fujitsu.com>
Message-ID: <20090219084728.9547.A69D9226@jp.fujitsu.com>

Hi

> We have to cleanup the lttng's root directory of debugfs if 
> there is nobody uses it any more.

Why "have to"?
This description don't explain anything.



 diff --git a/ltt/ltt-trace-control.c b/ltt/ltt-trace-control.c
> index 16502a2..0cdeb8a 100644
> --- a/ltt/ltt-trace-control.c
> +++ b/ltt/ltt-trace-control.c
> @@ -740,7 +740,8 @@ err_create_destroy_trace_file:
>  err_create_setup_trace_file:
>  	debugfs_remove(ltt_control_dir);
>  err_create_control_dir:
> -err_no_root:
> +	put_ltt_root();
> + err_no_root:

label indentation is considered bad conding style in lkml.