[ltt-dev] [PATCH] LTT_TRACEPROBES select LTT_RELAY_ALLOC

[ltt-dev] [PATCH] LTT_TRACEPROBES select LTT_RELAY_ALLOC

[KOSAKI Motohiro]

Impact: fix build error

Currently, ltt-type-serializer.c::_ltt_specialized_trace() is using ltt_relay_write().
Then, LTT_TRACEPROBES should turn on LTT_RELAY_ALLOC. otherwise, following build error happend.

	ltt/built-in.o: In function `ltt_relay_cache_page':
	include/linux/ltt-relay.h:198: undefined reference to `ltt_relay_find_next_page'
	include/linux/ltt-relay.h:201: undefined reference to `ltt_relay_find_prev_page'
	built-in.o: In function `ltt_relay_write':
	include/linux/ltt-relay.h:283: undefined reference to `_ltt_relay_write'
	make: *** [.tmp_vmlinux1] error 1

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
---
 ltt/Kconfig |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/ltt/Kconfig b/ltt/Kconfig
index 1347d6f..773d4d9 100644
--- a/ltt/Kconfig
+++ b/ltt/Kconfig
@@ -31,21 +31,23 @@ if LTT
 config LTT_FILTER
 	tristate
 
+config HAVE_LTT_DUMP_TABLES
+	def_bool n
+
+config LTT_RELAY_ALLOC
+	def_bool n
+
+
 config LTT_TRACEPROBES
 	tristate "Compile lttng tracing probes"
 	default m
 	select LTT_FILTER
+	select LTT_RELAY_ALLOC
 	help
 	  Compile lttng tracing probes, which connect to the tracepoints when
 	  loaded and format the information collected by the tracepoints with
 	  the Markers.
 
-config HAVE_LTT_DUMP_TABLES
-	def_bool n
-
-config LTT_RELAY_ALLOC
-	def_bool n
-
 config LTT_RELAY
 	tristate "Linux Trace Toolkit High-speed Lockless Data Relay"
 	depends on DEBUG_FS
-- 
1.6.0.6

[ltt-dev] [PATCH] LTT_TRACEPROBES select LTT_RELAY_ALLOC

[Mathieu Desnoyers]

* KOSAKI Motohiro (kosaki.motohiro at jp.fujitsu.com) wrote:
> 
> Impact: fix build error
> 
> Currently, ltt-type-serializer.c::_ltt_specialized_trace() is using ltt_relay_write().
> Then, LTT_TRACEPROBES should turn on LTT_RELAY_ALLOC. otherwise, following build error happend.
> 
> 	ltt/built-in.o: In function `ltt_relay_cache_page':
> 	include/linux/ltt-relay.h:198: undefined reference to `ltt_relay_find_next_page'
> 	include/linux/ltt-relay.h:201: undefined reference to `ltt_relay_find_prev_page'
> 	built-in.o: In function `ltt_relay_write':
> 	include/linux/ltt-relay.h:283: undefined reference to `_ltt_relay_write'
> 	make: *** [.tmp_vmlinux1] error 1
> 

I integrated something close to this fix in my local tree already.
Thanks.

Mathieu

> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
> ---
>  ltt/Kconfig |   14 ++++++++------
>  1 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/ltt/Kconfig b/ltt/Kconfig
> index 1347d6f..773d4d9 100644
> --- a/ltt/Kconfig
> +++ b/ltt/Kconfig
> @@ -31,21 +31,23 @@ if LTT
>  config LTT_FILTER
>  	tristate
>  
> +config HAVE_LTT_DUMP_TABLES
> +	def_bool n
> +
> +config LTT_RELAY_ALLOC
> +	def_bool n
> +
> +
>  config LTT_TRACEPROBES
>  	tristate "Compile lttng tracing probes"
>  	default m
>  	select LTT_FILTER
> +	select LTT_RELAY_ALLOC
>  	help
>  	  Compile lttng tracing probes, which connect to the tracepoints when
>  	  loaded and format the information collected by the tracepoints with
>  	  the Markers.
>  
> -config HAVE_LTT_DUMP_TABLES
> -	def_bool n
> -
> -config LTT_RELAY_ALLOC
> -	def_bool n
> -
>  config LTT_RELAY
>  	tristate "Linux Trace Toolkit High-speed Lockless Data Relay"
>  	depends on DEBUG_FS
> -- 
> 1.6.0.6
> 
> 
> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68