Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: kosaki.motohiro@jp.fujitsu.com (KOSAKI Motohiro)
Subject: [ltt-dev] [PATCH] LTT_TRACEPROBES select LTT_RELAY_ALLOC
Date: Tue, 10 Feb 2009 16:44:56 +0900 (JST)	[thread overview]
Message-ID: <20090210164334.6FC7.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)


Impact: fix build error

Currently, ltt-type-serializer.c::_ltt_specialized_trace() is using ltt_relay_write().
Then, LTT_TRACEPROBES should turn on LTT_RELAY_ALLOC. otherwise, following build error happend.

	ltt/built-in.o: In function `ltt_relay_cache_page':
	include/linux/ltt-relay.h:198: undefined reference to `ltt_relay_find_next_page'
	include/linux/ltt-relay.h:201: undefined reference to `ltt_relay_find_prev_page'
	built-in.o: In function `ltt_relay_write':
	include/linux/ltt-relay.h:283: undefined reference to `_ltt_relay_write'
	make: *** [.tmp_vmlinux1] error 1

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
---
 ltt/Kconfig |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/ltt/Kconfig b/ltt/Kconfig
index 1347d6f..773d4d9 100644
--- a/ltt/Kconfig
+++ b/ltt/Kconfig
@@ -31,21 +31,23 @@ if LTT
 config LTT_FILTER
 	tristate
 
+config HAVE_LTT_DUMP_TABLES
+	def_bool n
+
+config LTT_RELAY_ALLOC
+	def_bool n
+
+
 config LTT_TRACEPROBES
 	tristate "Compile lttng tracing probes"
 	default m
 	select LTT_FILTER
+	select LTT_RELAY_ALLOC
 	help
 	  Compile lttng tracing probes, which connect to the tracepoints when
 	  loaded and format the information collected by the tracepoints with
 	  the Markers.
 
-config HAVE_LTT_DUMP_TABLES
-	def_bool n
-
-config LTT_RELAY_ALLOC
-	def_bool n
-
 config LTT_RELAY
 	tristate "Linux Trace Toolkit High-speed Lockless Data Relay"
 	depends on DEBUG_FS
-- 
1.6.0.6







             reply	other threads:[~2009-02-10  7:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-10  7:44 KOSAKI Motohiro [this message]
2009-02-11  5:00 ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090210164334.6FC7.KOSAKI.MOTOHIRO@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox