[ltt-dev] [PATCH 1/4] Make _ltt_trace_find simpler

[ltt-dev] [PATCH 1/4] Make _ltt_trace_find simpler

[Zhaolei]

Avoid using 2 local variables.

Impact: cleanup, no functionality changed

Signed-off-by: Zhao Lei <zhaolei at cn.fujitsu.com>
---
 ltt/ltt-tracer.c |   16 +++++-----------
 1 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/ltt/ltt-tracer.c b/ltt/ltt-tracer.c
index bc8251b..92677a2 100644
--- a/ltt/ltt-tracer.c
+++ b/ltt/ltt-tracer.c
@@ -259,19 +259,13 @@ static void async_wakeup(unsigned long data)
  * Returns a pointer to the trace structure, NULL if not found. */
 static struct ltt_trace_struct *_ltt_trace_find(char *trace_name)
 {
-	int compare;
-	struct ltt_trace_struct *trace, *found = NULL;
-
-	list_for_each_entry(trace, &ltt_traces.head, list) {
-		compare = strncmp(trace->trace_name, trace_name, NAME_MAX);
+	struct ltt_trace_struct *trace;
 
-		if (compare == 0) {
-			found = trace;
-			break;
-		}
-	}
+	list_for_each_entry(trace, &ltt_traces.head, list)
+		if (!strncmp(trace->trace_name, trace_name, NAME_MAX))
+			return trace;
 
-	return found;
+	return NULL;
 }
 
 /* This function must be called with traces semaphore held. */
-- 
1.5.5.3

[ltt-dev] [PATCH 1/4] Make _ltt_trace_find simpler

[Mathieu Desnoyers]

* Zhaolei (zhaolei at cn.fujitsu.com) wrote:
> Avoid using 2 local variables.
> 
> Impact: cleanup, no functionality changed
> 

Merged, thanks !

Mathieu

> Signed-off-by: Zhao Lei <zhaolei at cn.fujitsu.com>
> ---
>  ltt/ltt-tracer.c |   16 +++++-----------
>  1 files changed, 5 insertions(+), 11 deletions(-)
> 
> diff --git a/ltt/ltt-tracer.c b/ltt/ltt-tracer.c
> index bc8251b..92677a2 100644
> --- a/ltt/ltt-tracer.c
> +++ b/ltt/ltt-tracer.c
> @@ -259,19 +259,13 @@ static void async_wakeup(unsigned long data)
>   * Returns a pointer to the trace structure, NULL if not found. */
>  static struct ltt_trace_struct *_ltt_trace_find(char *trace_name)
>  {
> -	int compare;
> -	struct ltt_trace_struct *trace, *found = NULL;
> -
> -	list_for_each_entry(trace, &ltt_traces.head, list) {
> -		compare = strncmp(trace->trace_name, trace_name, NAME_MAX);
> +	struct ltt_trace_struct *trace;
>  
> -		if (compare == 0) {
> -			found = trace;
> -			break;
> -		}
> -	}
> +	list_for_each_entry(trace, &ltt_traces.head, list)
> +		if (!strncmp(trace->trace_name, trace_name, NAME_MAX))
> +			return trace;
>  
> -	return found;
> +	return NULL;
>  }
>  
>  /* This function must be called with traces semaphore held. */
> -- 
> 1.5.5.3
> 
> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68