Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: zhaolei@cn.fujitsu.com (Zhaolei)
Subject: [ltt-dev] [PATCH 1/4] Make _ltt_trace_find simpler
Date: Thu, 23 Oct 2008 18:45:37 +0800	[thread overview]
Message-ID: <490055D1.3080106@cn.fujitsu.com> (raw)

Avoid using 2 local variables.

Impact: cleanup, no functionality changed

Signed-off-by: Zhao Lei <zhaolei at cn.fujitsu.com>
---
 ltt/ltt-tracer.c |   16 +++++-----------
 1 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/ltt/ltt-tracer.c b/ltt/ltt-tracer.c
index bc8251b..92677a2 100644
--- a/ltt/ltt-tracer.c
+++ b/ltt/ltt-tracer.c
@@ -259,19 +259,13 @@ static void async_wakeup(unsigned long data)
  * Returns a pointer to the trace structure, NULL if not found. */
 static struct ltt_trace_struct *_ltt_trace_find(char *trace_name)
 {
-	int compare;
-	struct ltt_trace_struct *trace, *found = NULL;
-
-	list_for_each_entry(trace, &ltt_traces.head, list) {
-		compare = strncmp(trace->trace_name, trace_name, NAME_MAX);
+	struct ltt_trace_struct *trace;
 
-		if (compare == 0) {
-			found = trace;
-			break;
-		}
-	}
+	list_for_each_entry(trace, &ltt_traces.head, list)
+		if (!strncmp(trace->trace_name, trace_name, NAME_MAX))
+			return trace;
 
-	return found;
+	return NULL;
 }
 
 /* This function must be called with traces semaphore held. */
-- 
1.5.5.3






             reply	other threads:[~2008-10-23 10:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-23 10:45 Zhaolei [this message]
2008-10-24 14:17 ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490055D1.3080106@cn.fujitsu.com \
    --to=zhaolei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox