* [ltt-dev] [UST PATCH] Initialize _res_header variable to zero before use in process_client_cmd
@ 2011-02-22 23:30 Yannick Brosseau
2011-02-23 9:11 ` Nils Carlson
0 siblings, 1 reply; 6+ messages in thread
From: Yannick Brosseau @ 2011-02-22 23:30 UTC (permalink / raw)
This use of a non-initialized variable was detected by the valgrind test.
Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
---
libustconsumer/libustconsumer.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libustconsumer/libustconsumer.c b/libustconsumer/libustconsumer.c
index 25c84ce..c51b106 100644
--- a/libustconsumer/libustconsumer.c
+++ b/libustconsumer/libustconsumer.c
@@ -621,7 +621,7 @@ static void process_client_cmd(int sock, struct ustcomm_header *req_header,
char *recvbuf, struct ustconsumer_instance *instance)
{
int result;
- struct ustcomm_header _res_header;
+ struct ustcomm_header _res_header = {0};
struct ustcomm_header *res_header = &_res_header;
struct ustcomm_buffer_info *buf_inf;
--
1.7.2.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ltt-dev] [UST PATCH] Initialize _res_header variable to zero before use in process_client_cmd
2011-02-22 23:30 [ltt-dev] [UST PATCH] Initialize _res_header variable to zero before use in process_client_cmd Yannick Brosseau
@ 2011-02-23 9:11 ` Nils Carlson
2011-02-23 15:41 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP243E1ABCB7AA82363C368C96DB0@phx.gbl>
0 siblings, 2 replies; 6+ messages in thread
From: Nils Carlson @ 2011-02-23 9:11 UTC (permalink / raw)
On Wed, 23 Feb 2011, Yannick Brosseau wrote:
> This use of a non-initialized variable was detected by the valgrind test.
>
> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
Acked-by: Nils Carlson <nils.carlson at ericsson.com>
> ---
> libustconsumer/libustconsumer.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libustconsumer/libustconsumer.c b/libustconsumer/libustconsumer.c
> index 25c84ce..c51b106 100644
> --- a/libustconsumer/libustconsumer.c
> +++ b/libustconsumer/libustconsumer.c
> @@ -621,7 +621,7 @@ static void process_client_cmd(int sock, struct ustcomm_header *req_header,
> char *recvbuf, struct ustconsumer_instance *instance)
> {
> int result;
> - struct ustcomm_header _res_header;
> + struct ustcomm_header _res_header = {0};
> struct ustcomm_header *res_header = &_res_header;
> struct ustcomm_buffer_info *buf_inf;
>
> --
> 1.7.2.3
>
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ltt-dev] [UST PATCH] Initialize _res_header variable to zero before use in process_client_cmd
2011-02-23 9:11 ` Nils Carlson
@ 2011-02-23 15:41 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP243E1ABCB7AA82363C368C96DB0@phx.gbl>
1 sibling, 0 replies; 6+ messages in thread
From: Mathieu Desnoyers @ 2011-02-23 15:41 UTC (permalink / raw)
* Nils Carlson (nils.carlson at ericsson.com) wrote:
>
>
> On Wed, 23 Feb 2011, Yannick Brosseau wrote:
>
>> This use of a non-initialized variable was detected by the valgrind test.
>>
>> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
>
> Acked-by: Nils Carlson <nils.carlson at ericsson.com>
Hi Nils,
Please use "Signed-off-by" in the git commit when you are on the merge
path. Otherwise, "Acked-by" would mean that you agree with the patch,
but are not involved in the commit.
Acked-by in the reply here required me to go dig in the git log to see
if it had been merged.
Thanks,
Mathieu
>> ---
>> libustconsumer/libustconsumer.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/libustconsumer/libustconsumer.c b/libustconsumer/libustconsumer.c
>> index 25c84ce..c51b106 100644
>> --- a/libustconsumer/libustconsumer.c
>> +++ b/libustconsumer/libustconsumer.c
>> @@ -621,7 +621,7 @@ static void process_client_cmd(int sock, struct ustcomm_header *req_header,
>> char *recvbuf, struct ustconsumer_instance *instance)
>> {
>> int result;
>> - struct ustcomm_header _res_header;
>> + struct ustcomm_header _res_header = {0};
>> struct ustcomm_header *res_header = &_res_header;
>> struct ustcomm_buffer_info *buf_inf;
>>
>> --
>> 1.7.2.3
>>
>>
>> _______________________________________________
>> ltt-dev mailing list
>> ltt-dev at lists.casi.polymtl.ca
>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ltt-dev] [UST PATCH] Initialize _res_header variable to zero before use in process_client_cmd
2011-02-23 16:04 ` Nils Carlson
@ 2011-02-23 15:51 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP68D3FDFD4FBB093BB2E42B96DB0@phx.gbl>
1 sibling, 0 replies; 6+ messages in thread
From: Mathieu Desnoyers @ 2011-02-23 15:51 UTC (permalink / raw)
* Nils Carlson (nils.carlson at ericsson.com) wrote:
> ok. will do. For reference I merge everything I ack.
OK, although I propose we both standardize on:
Acked-by: agreeing, not merging.
Signed-off-by: merging.
Because there will be patches (and moments) where I will want to say
"I'm ok with the patch, but I don't have time to handle the merge
myself". And Acked-by is a pretty good way to express that by email.
Thanks,
Mathieu
>
> /Nils
>
> On Wed, 23 Feb 2011, Mathieu Desnoyers wrote:
>
>> * Nils Carlson (nils.carlson at ericsson.com) wrote:
>>>
>>>
>>> On Wed, 23 Feb 2011, Yannick Brosseau wrote:
>>>
>>>> This use of a non-initialized variable was detected by the valgrind test.
>>>>
>>>> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
>>>
>>> Acked-by: Nils Carlson <nils.carlson at ericsson.com>
>>
>> Hi Nils,
>>
>> Please use "Signed-off-by" in the git commit when you are on the merge
>> path. Otherwise, "Acked-by" would mean that you agree with the patch,
>> but are not involved in the commit.
>>
>> Acked-by in the reply here required me to go dig in the git log to see
>> if it had been merged.
>>
>> Thanks,
>>
>> Mathieu
>>
>>>> ---
>>>> libustconsumer/libustconsumer.c | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/libustconsumer/libustconsumer.c b/libustconsumer/libustconsumer.c
>>>> index 25c84ce..c51b106 100644
>>>> --- a/libustconsumer/libustconsumer.c
>>>> +++ b/libustconsumer/libustconsumer.c
>>>> @@ -621,7 +621,7 @@ static void process_client_cmd(int sock, struct ustcomm_header *req_header,
>>>> char *recvbuf, struct ustconsumer_instance *instance)
>>>> {
>>>> int result;
>>>> - struct ustcomm_header _res_header;
>>>> + struct ustcomm_header _res_header = {0};
>>>> struct ustcomm_header *res_header = &_res_header;
>>>> struct ustcomm_buffer_info *buf_inf;
>>>>
>>>> --
>>>> 1.7.2.3
>>>>
>>>>
>>>> _______________________________________________
>>>> ltt-dev mailing list
>>>> ltt-dev at lists.casi.polymtl.ca
>>>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>>>
>>>
>>> _______________________________________________
>>> ltt-dev mailing list
>>> ltt-dev at lists.casi.polymtl.ca
>>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>>
>>
>> --
>> Mathieu Desnoyers
>> Operating System Efficiency R&D Consultant
>> EfficiOS Inc.
>> http://www.efficios.com
>>
>
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ltt-dev] [UST PATCH] Initialize _res_header variable to zero before use in process_client_cmd
[not found] ` <BLU0-SMTP243E1ABCB7AA82363C368C96DB0@phx.gbl>
@ 2011-02-23 16:04 ` Nils Carlson
2011-02-23 15:51 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP68D3FDFD4FBB093BB2E42B96DB0@phx.gbl>
0 siblings, 2 replies; 6+ messages in thread
From: Nils Carlson @ 2011-02-23 16:04 UTC (permalink / raw)
ok. will do. For reference I merge everything I ack.
/Nils
On Wed, 23 Feb 2011, Mathieu Desnoyers wrote:
> * Nils Carlson (nils.carlson at ericsson.com) wrote:
>>
>>
>> On Wed, 23 Feb 2011, Yannick Brosseau wrote:
>>
>>> This use of a non-initialized variable was detected by the valgrind test.
>>>
>>> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
>>
>> Acked-by: Nils Carlson <nils.carlson at ericsson.com>
>
> Hi Nils,
>
> Please use "Signed-off-by" in the git commit when you are on the merge
> path. Otherwise, "Acked-by" would mean that you agree with the patch,
> but are not involved in the commit.
>
> Acked-by in the reply here required me to go dig in the git log to see
> if it had been merged.
>
> Thanks,
>
> Mathieu
>
>>> ---
>>> libustconsumer/libustconsumer.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/libustconsumer/libustconsumer.c b/libustconsumer/libustconsumer.c
>>> index 25c84ce..c51b106 100644
>>> --- a/libustconsumer/libustconsumer.c
>>> +++ b/libustconsumer/libustconsumer.c
>>> @@ -621,7 +621,7 @@ static void process_client_cmd(int sock, struct ustcomm_header *req_header,
>>> char *recvbuf, struct ustconsumer_instance *instance)
>>> {
>>> int result;
>>> - struct ustcomm_header _res_header;
>>> + struct ustcomm_header _res_header = {0};
>>> struct ustcomm_header *res_header = &_res_header;
>>> struct ustcomm_buffer_info *buf_inf;
>>>
>>> --
>>> 1.7.2.3
>>>
>>>
>>> _______________________________________________
>>> ltt-dev mailing list
>>> ltt-dev at lists.casi.polymtl.ca
>>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>>
>>
>> _______________________________________________
>> ltt-dev mailing list
>> ltt-dev at lists.casi.polymtl.ca
>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>
>
> --
> Mathieu Desnoyers
> Operating System Efficiency R&D Consultant
> EfficiOS Inc.
> http://www.efficios.com
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ltt-dev] [UST PATCH] Initialize _res_header variable to zero before use in process_client_cmd
[not found] ` <BLU0-SMTP68D3FDFD4FBB093BB2E42B96DB0@phx.gbl>
@ 2011-02-23 16:15 ` Nils Carlson
0 siblings, 0 replies; 6+ messages in thread
From: Nils Carlson @ 2011-02-23 16:15 UTC (permalink / raw)
On Wed, 23 Feb 2011, Mathieu Desnoyers wrote:
> * Nils Carlson (nils.carlson at ericsson.com) wrote:
>> ok. will do. For reference I merge everything I ack.
>
> OK, although I propose we both standardize on:
>
> Acked-by: agreeing, not merging.
> Signed-off-by: merging.
>
> Because there will be patches (and moments) where I will want to say
> "I'm ok with the patch, but I don't have time to handle the merge
> myself". And Acked-by is a pretty good way to express that by email.
>
Ok. Good to have policy.
/Nils
> Thanks,
>
> Mathieu
>
>>
>> /Nils
>>
>> On Wed, 23 Feb 2011, Mathieu Desnoyers wrote:
>>
>>> * Nils Carlson (nils.carlson at ericsson.com) wrote:
>>>>
>>>>
>>>> On Wed, 23 Feb 2011, Yannick Brosseau wrote:
>>>>
>>>>> This use of a non-initialized variable was detected by the valgrind test.
>>>>>
>>>>> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
>>>>
>>>> Acked-by: Nils Carlson <nils.carlson at ericsson.com>
>>>
>>> Hi Nils,
>>>
>>> Please use "Signed-off-by" in the git commit when you are on the merge
>>> path. Otherwise, "Acked-by" would mean that you agree with the patch,
>>> but are not involved in the commit.
>>>
>>> Acked-by in the reply here required me to go dig in the git log to see
>>> if it had been merged.
>>>
>>> Thanks,
>>>
>>> Mathieu
>>>
>>>>> ---
>>>>> libustconsumer/libustconsumer.c | 2 +-
>>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>>
>>>>> diff --git a/libustconsumer/libustconsumer.c b/libustconsumer/libustconsumer.c
>>>>> index 25c84ce..c51b106 100644
>>>>> --- a/libustconsumer/libustconsumer.c
>>>>> +++ b/libustconsumer/libustconsumer.c
>>>>> @@ -621,7 +621,7 @@ static void process_client_cmd(int sock, struct ustcomm_header *req_header,
>>>>> char *recvbuf, struct ustconsumer_instance *instance)
>>>>> {
>>>>> int result;
>>>>> - struct ustcomm_header _res_header;
>>>>> + struct ustcomm_header _res_header = {0};
>>>>> struct ustcomm_header *res_header = &_res_header;
>>>>> struct ustcomm_buffer_info *buf_inf;
>>>>>
>>>>> --
>>>>> 1.7.2.3
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> ltt-dev mailing list
>>>>> ltt-dev at lists.casi.polymtl.ca
>>>>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>>>>
>>>>
>>>> _______________________________________________
>>>> ltt-dev mailing list
>>>> ltt-dev at lists.casi.polymtl.ca
>>>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>>>
>>>
>>> --
>>> Mathieu Desnoyers
>>> Operating System Efficiency R&D Consultant
>>> EfficiOS Inc.
>>> http://www.efficios.com
>>>
>>
>
> --
> Mathieu Desnoyers
> Operating System Efficiency R&D Consultant
> EfficiOS Inc.
> http://www.efficios.com
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-02-23 16:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-22 23:30 [ltt-dev] [UST PATCH] Initialize _res_header variable to zero before use in process_client_cmd Yannick Brosseau
2011-02-23 9:11 ` Nils Carlson
2011-02-23 15:41 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP243E1ABCB7AA82363C368C96DB0@phx.gbl>
2011-02-23 16:04 ` Nils Carlson
2011-02-23 15:51 ` Mathieu Desnoyers
[not found] ` <BLU0-SMTP68D3FDFD4FBB093BB2E42B96DB0@phx.gbl>
2011-02-23 16:15 ` Nils Carlson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox