[ltt-dev] [UST PATCH] Initialize _res_header variable to zero before use in process_client_cmd

[compudj@krystal.dyndns.org (Mathieu Desnoyers)]

* Nils Carlson (nils.carlson at ericsson.com) wrote:
> ok. will do. For reference I merge everything I ack.

OK, although I propose we both standardize on:

Acked-by: agreeing, not merging.
Signed-off-by: merging.

Because there will be patches (and moments) where I will want to say
"I'm ok with the patch, but I don't have time to handle the merge
myself". And Acked-by is a pretty good way to express that by email.

Thanks,

Mathieu

>
> /Nils
>
> On Wed, 23 Feb 2011, Mathieu Desnoyers wrote:
>
>> * Nils Carlson (nils.carlson at ericsson.com) wrote:
>>>
>>>
>>> On Wed, 23 Feb 2011, Yannick Brosseau wrote:
>>>
>>>> This use of a non-initialized variable was detected by the valgrind test.
>>>>
>>>> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
>>>
>>> Acked-by: Nils Carlson <nils.carlson at ericsson.com>
>>
>> Hi Nils,
>>
>> Please use "Signed-off-by" in the git commit when you are on the merge
>> path. Otherwise, "Acked-by" would mean that you agree with the patch,
>> but are not involved in the commit.
>>
>> Acked-by in the reply here required me to go dig in the git log to see
>> if it had been merged.
>>
>> Thanks,
>>
>> Mathieu
>>
>>>> ---
>>>> libustconsumer/libustconsumer.c |    2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/libustconsumer/libustconsumer.c b/libustconsumer/libustconsumer.c
>>>> index 25c84ce..c51b106 100644
>>>> --- a/libustconsumer/libustconsumer.c
>>>> +++ b/libustconsumer/libustconsumer.c
>>>> @@ -621,7 +621,7 @@ static void process_client_cmd(int sock, struct ustcomm_header *req_header,
>>>> 			       char *recvbuf, struct ustconsumer_instance *instance)
>>>> {
>>>> 	int result;
>>>> -	struct ustcomm_header _res_header;
>>>> +	struct ustcomm_header _res_header = {0};
>>>> 	struct ustcomm_header *res_header = &_res_header;
>>>> 	struct ustcomm_buffer_info *buf_inf;
>>>>
>>>> --
>>>> 1.7.2.3
>>>>
>>>>
>>>> _______________________________________________
>>>> ltt-dev mailing list
>>>> ltt-dev at lists.casi.polymtl.ca
>>>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>>>
>>>
>>> _______________________________________________
>>> ltt-dev mailing list
>>> ltt-dev at lists.casi.polymtl.ca
>>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>>
>>
>> -- 
>> Mathieu Desnoyers
>> Operating System Efficiency R&D Consultant
>> EfficiOS Inc.
>> http://www.efficios.com
>>
>

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com