[ltt-dev] [RFC UST PATCH] Removes useless ___cacheline_aligned

[ltt-dev] [RFC UST PATCH] Removes useless ___cacheline_aligned

[David Goulet]

Signed-off-by: David Goulet <david.goulet at polymtl.ca>
---
 libust/buffers.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libust/buffers.h b/libust/buffers.h
index 63449d6..1ae2208 100644
--- a/libust/buffers.h
+++ b/libust/buffers.h
@@ -96,7 +96,7 @@ struct ust_buffer {
 	unsigned int cpu;
 
 	/* commit count per subbuffer; must be at end of struct */
-	long commit_seq[0] ____cacheline_aligned; /* ATOMIC */
+	long commit_seq[0]; /* ATOMIC */
/*
 * This might be useful and there for a reason... but after
 * some test and thought, I don't think so. Since commit_seq is 0,
 * there is no lost of memory here anyway...
 */
 } ____cacheline_aligned;
 
 /*
-- 
1.7.0.4

[ltt-dev] [RFC UST PATCH] Removes useless ___cacheline_aligned

[Mathieu Desnoyers]

* David Goulet (david.goulet at polymtl.ca) wrote:
> Signed-off-by: David Goulet <david.goulet at polymtl.ca>
> ---
>  libust/buffers.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libust/buffers.h b/libust/buffers.h
> index 63449d6..1ae2208 100644
> --- a/libust/buffers.h
> +++ b/libust/buffers.h
> @@ -96,7 +96,7 @@ struct ust_buffer {
>  	unsigned int cpu;
>  
>  	/* commit count per subbuffer; must be at end of struct */
> -	long commit_seq[0] ____cacheline_aligned; /* ATOMIC */
> +	long commit_seq[0]; /* ATOMIC */
> /*
>  * This might be useful and there for a reason... but after
>  * some test and thought, I don't think so. Since commit_seq is 0,
>  * there is no lost of memory here anyway...

Yeah, I really don't know what this is supposed to do. Should be
removed.

Thanks,

Mathieu

>  */
>  } ____cacheline_aligned;
>  
>  /*
> -- 
> 1.7.0.4
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com