From: mathieu.desnoyers@polymtl.ca (Mathieu Desnoyers)
Subject: [ltt-dev] [RFC UST PATCH] Removes useless ___cacheline_aligned
Date: Wed, 18 Aug 2010 16:33:40 -0400 [thread overview]
Message-ID: <20100818203340.GA21756@Krystal> (raw)
In-Reply-To: <1282160408-24122-1-git-send-email-david.goulet@polymtl.ca>
* David Goulet (david.goulet at polymtl.ca) wrote:
> Signed-off-by: David Goulet <david.goulet at polymtl.ca>
> ---
> libust/buffers.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libust/buffers.h b/libust/buffers.h
> index 63449d6..1ae2208 100644
> --- a/libust/buffers.h
> +++ b/libust/buffers.h
> @@ -96,7 +96,7 @@ struct ust_buffer {
> unsigned int cpu;
>
> /* commit count per subbuffer; must be at end of struct */
> - long commit_seq[0] ____cacheline_aligned; /* ATOMIC */
> + long commit_seq[0]; /* ATOMIC */
> /*
> * This might be useful and there for a reason... but after
> * some test and thought, I don't think so. Since commit_seq is 0,
> * there is no lost of memory here anyway...
Yeah, I really don't know what this is supposed to do. Should be
removed.
Thanks,
Mathieu
> */
> } ____cacheline_aligned;
>
> /*
> --
> 1.7.0.4
>
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
prev parent reply other threads:[~2010-08-18 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 19:40 David Goulet
2010-08-18 20:33 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818203340.GA21756@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox