From: Andreas Schwab <schwab@redhat.com>
To: "Pierre Muller" <muller@ics.u-strasbg.fr>
Cc: "'Ralf Corsepius'" <ralf.corsepius@rtems.org>,
"'Joel Brobecker'" <brobecker@adacore.com>,
<gdb@sourceware.org>,
"'Jan Kratochvil'" <jan.kratochvil@redhat.com>,
"'Tom Tromey'" <tromey@redhat.com>
Subject: Re: GDB 6.8.92 available for testing
Date: Thu, 01 Oct 2009 09:42:00 -0000 [thread overview]
Message-ID: <m3bpkra1vk.fsf@hase.home> (raw)
In-Reply-To: <002e01ca427a$5f1363b0$1d3a2b10$@u-strasbg.fr> (Pierre Muller's message of "Thu, 1 Oct 2009 11:34:28 +0200")
"Pierre Muller" <muller@ics.u-strasbg.fr> writes:
> Andreas,
>
> why don't you simply use this?
> #if RL_VERSION_MAJOR >= 6
> extern int _rl_echoing_p;
> #define readline_echoing_p _rl_echoing_p
> #else
> extern int readline_echoing_p;
> #endif
>
> This would make your patch simpler, no?
>
> Is there a reason for replacing all
> readline_echoing_p by _rl_echoing_p?
As explained in the mail, I want to emphasize that it is an internal
readline variable (as noticeable from the leading underscore).
Andreas.
--
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E
"And now for something completely different."
next prev parent reply other threads:[~2009-10-01 9:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 20:48 Joel Brobecker
2009-10-01 3:17 ` Ralf Corsepius
2009-10-01 8:59 ` Andreas Schwab
2009-10-01 9:35 ` Pierre Muller
2009-10-01 9:42 ` Andreas Schwab [this message]
2009-10-01 12:11 ` Ralf Corsepius
2009-10-01 13:10 ` Jan Kratochvil
2009-10-02 15:40 ` Tom Tromey
2009-10-02 17:26 ` Jan Kratochvil
2009-10-01 10:09 ` Jan Kratochvil
2009-10-01 11:20 ` Ralf Corsepius
2009-10-01 18:16 ` Joel Brobecker
2009-10-02 2:46 ` Ralf Corsepius
2009-10-02 15:39 ` Tom Tromey
2009-10-02 17:28 ` Jan Kratochvil
2009-10-01 17:07 ` Joel Brobecker
2009-10-01 17:21 ` Ralf Corsepius
2009-10-01 17:35 ` Mark Kettenis
2009-10-01 18:27 ` Joel Brobecker
2009-10-01 18:37 ` Mark Kettenis
2009-10-01 20:22 ` Eli Zaretskii
2009-10-01 18:40 ` Paul Pluzhnikov
2009-10-01 18:25 ` Joel Brobecker
2009-10-02 15:48 ` Tom Tromey
2009-10-02 16:57 ` Ralf Corsepius
2009-10-02 17:27 ` Tom Tromey
2009-10-02 18:04 ` Mark Kettenis
2009-10-02 18:15 ` Joel Brobecker
2009-10-02 18:24 ` Mark Kettenis
2009-10-02 18:38 ` Jan Kratochvil
2009-10-02 21:46 ` Tom Tromey
2009-10-02 22:00 ` Jan Kratochvil
2009-10-02 15:35 ` Tom Tromey
2009-10-01 12:02 ` Pierre Muller
2009-10-01 17:56 ` Joel Brobecker
2009-10-01 21:22 ` [RFA] more fixes to testsuite (was RE: GDB 6.8.92 available for testing) Pierre Muller
2009-10-01 21:28 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bpkra1vk.fsf@hase.home \
--to=schwab@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=muller@ics.u-strasbg.fr \
--cc=ralf.corsepius@rtems.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox