From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-35737-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 18182 invoked by alias); 1 Oct 2009 09:42:22 -0000
Received: (qmail 18171 invoked by uid 22791); 1 Oct 2009 09:42:21 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Oct 2009 09:42:14 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n919eXZI018957; 	Thu, 1 Oct 2009 05:40:34 -0400
Received: from hase.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n919eGJZ008425; 	Thu, 1 Oct 2009 05:40:27 -0400
From: Andreas Schwab <schwab@redhat.com>
To: "Pierre Muller" <muller@ics.u-strasbg.fr>
Cc: "'Ralf Corsepius'" <ralf.corsepius@rtems.org>,         "'Joel Brobecker'" <brobecker@adacore.com>, <gdb@sourceware.org>,         "'Jan Kratochvil'" <jan.kratochvil@redhat.com>,         "'Tom Tromey'" <tromey@redhat.com>
Subject: Re: GDB 6.8.92 available for testing
References: <20090930204828.GB31446@adacore.com> <4AC41F44.1040502@rtems.org> 	<m3ljjva3tl.fsf@hase.home> 	<002e01ca427a$5f1363b0$1d3a2b10$@u-strasbg.fr>
X-Yow: I know things about TROY DONAHUE that can't even be PRINTED!!
Date: Thu, 01 Oct 2009 09:42:00 -0000
In-Reply-To: <002e01ca427a$5f1363b0$1d3a2b10$@u-strasbg.fr> (Pierre Muller's 	message of "Thu, 1 Oct 2009 11:34:28 +0200")
Message-ID: <m3bpkra1vk.fsf@hase.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00010.txt.bz2

"Pierre Muller" <muller@ics.u-strasbg.fr> writes:

> Andreas,
>
> why don't you simply use this?
> #if RL_VERSION_MAJOR >= 6
>   extern int _rl_echoing_p;
> #define readline_echoing_p _rl_echoing_p 
> #else
>    extern int readline_echoing_p;
> #endif
>
>   This would make your patch simpler, no?
>
> Is there a reason for replacing all
> readline_echoing_p by _rl_echoing_p?

As explained in the mail, I want to emphasize that it is an internal
readline variable (as noticeable from the leading underscore).

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."