Mirror of the gdb mailing list
 help / color / mirror / Atom feed
* obsolete comment in m68klinux-nat.c...
@ 2009-04-16  7:09 Joel Brobecker
  2009-04-16 13:14 ` Andreas Schwab
  0 siblings, 1 reply; 2+ messages in thread
From: Joel Brobecker @ 2009-04-16  7:09 UTC (permalink / raw)
  To: schwab; +Cc: gdb

Andreas,

We're trying to cleanup a bit the ARI output, and one of the macros
that was deprecated and now is no longer used (FETCH_INFERIOR_REGISTERS)
is only mentioned in a comment inside m68klinux-nat.c.

/* FIXME: This duplicates code from `inptrace.c'.  The problem is that we
   define FETCH_INFERIOR_REGISTERS since we want to use our own versions
   of {fetch,store}_inferior_registers that use the GETREGS request.  This
   means that the code in `infptrace.c' is #ifdef'd out.  But we need to
   fall back on that code when GDB is running on top of a kernel that
   doesn't support the GETREGS request.  */

I can see that the duplication is still there, but I think that things
might have changed quite a bit since the FIXME was written.  It looks
like you are maintaining GDB on that platform, so I was wondering if
you could take a look at the comment and maybe update it a bit?

Thank you!
-- 
Joel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: obsolete comment in m68klinux-nat.c...
  2009-04-16  7:09 obsolete comment in m68klinux-nat.c Joel Brobecker
@ 2009-04-16 13:14 ` Andreas Schwab
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Schwab @ 2009-04-16 13:14 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb

Joel Brobecker <brobecker@adacore.com> writes:

> I can see that the duplication is still there, but I think that things
> might have changed quite a bit since the FIXME was written.  It looks
> like you are maintaining GDB on that platform, so I was wondering if
> you could take a look at the comment and maybe update it a bit?

The situation is no different from i386-linux-nat.c, which can get away
without such a comment.  I'll remove it and simplify fetch_register and
store_register along the way.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-16 11:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-16  7:09 obsolete comment in m68klinux-nat.c Joel Brobecker
2009-04-16 13:14 ` Andreas Schwab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox