From: Joel Brobecker <brobecker@adacore.com>
To: schwab@linux-m68k.org
Cc: gdb@sourceware.org
Subject: obsolete comment in m68klinux-nat.c...
Date: Thu, 16 Apr 2009 07:09:00 -0000 [thread overview]
Message-ID: <20090416070008.GH7603@adacore.com> (raw)
Andreas,
We're trying to cleanup a bit the ARI output, and one of the macros
that was deprecated and now is no longer used (FETCH_INFERIOR_REGISTERS)
is only mentioned in a comment inside m68klinux-nat.c.
/* FIXME: This duplicates code from `inptrace.c'. The problem is that we
define FETCH_INFERIOR_REGISTERS since we want to use our own versions
of {fetch,store}_inferior_registers that use the GETREGS request. This
means that the code in `infptrace.c' is #ifdef'd out. But we need to
fall back on that code when GDB is running on top of a kernel that
doesn't support the GETREGS request. */
I can see that the duplication is still there, but I think that things
might have changed quite a bit since the FIXME was written. It looks
like you are maintaining GDB on that platform, so I was wondering if
you could take a look at the comment and maybe update it a bit?
Thank you!
--
Joel
next reply other threads:[~2009-04-16 7:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 7:09 Joel Brobecker [this message]
2009-04-16 13:14 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416070008.GH7603@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox