When may I close a 5.1.1 PR?

When may I close a 5.1.1 PR?

[Michael Elizabeth Chastain]

So last week I filed this PR:

  http://sources.redhat.com/cgi-bin/gnatsweb.pl?database=gdb&cmd=view&pr=334

This is a test failure in 5.1.1, but it is fixed in gdb HEAD (the mainline).

As a general question, when is a good time to close a PR that is fixed
in the mainline but not in the 5.1 branches:

  . after gdb 5.2 is released?
  . after gdb 5.2 is branched?
  . as soon as the bug is fixed in mainline?

I'll be happy to do whatever the voices in my mailbox tell me.  :)

Michael C

Re: When may I close a 5.1.1 PR?

[Eli Zaretskii]

On Sun, 10 Feb 2002, Michael Elizabeth Chastain wrote:

> As a general question, when is a good time to close a PR that is fixed
> in the mainline but not in the 5.1 branches:

Can't you add a comment that it's fixed in mainline, and then close it?

Re: When may I close a 5.1.1 PR?

[Andrew Cagney]

> So last week I filed this PR:
> 
>   http://sources.redhat.com/cgi-bin/gnatsweb.pl?database=gdb&cmd=view&pr=334
> 
> This is a test failure in 5.1.1, but it is fixed in gdb HEAD (the mainline).
> 
> As a general question, when is a good time to close a PR that is fixed
> in the mainline but not in the 5.1 branches:
> 
>   . after gdb 5.2 is released?
>   . after gdb 5.2 is branched?
>   . as soon as the bug is fixed in mainline?
> 
> I'll be happy to do whatever the voices in my mailbox tell me.  :)

I'm just happy to see the problem and fix recorded.  Probably close it 
since I assume no one has any intention of fixing it on the branch.

--

As an aside, I've been wondering what to do with the page:
http://sources.redhat.com/gdb/bugs/
I was thinking that it should just jump to the bug database.  However, 
looking around I've noticed that other projects have (for an equivalent 
page) used it to ``educate'' the reader as to how to submit a better bug 
report and where to find potential fixes..  I'm not sure we want to go 
down that path.  However, having the gdb/bugs/ page draw peoples 
attention to the current sources (http://sources.redhat.com/gdb/current) 
could help.

thoughts?
Andrew

Re: When may I close a 5.1.1 PR?

[Michael Elizabeth Chastain]

Andrew Cagney writes:

> I'm just happy to see the problem and fix recorded.  Probably close it 
> since I assume no one has any intention of fixing it on the branch.

That works for me.  I'll review some more of the open bugs and see
if they are fixed in HEAD now.

> I was thinking that it should just jump to the bug database.  However, 
> looking around I've noticed that other projects have (for an equivalent 
> page) used it to ``educate'' the reader as to how to submit a better bug 
> report and where to find potential fixes..  I'm not sure we want to go 
> down that path.

I like this idea.  We see a lot of reports that do not include the
target architecture or the version string.  Also it's very useful to
see what compiler the user built their program with.

It's a service to us if the bug reports are better to begin with.
It would be a service to the users if we say: if your gdb is version
4.18 or 5.0, then you should upgrade to 5.1.1 or the latest CVS version
before sending a letter at all.

Michael C