Re: [PATCH] prep for Tcl/Tk 8.3 upgrade

Re: [PATCH] prep for Tcl/Tk 8.3 upgrade

[Fernando Nasser]

Ian Roxborough wrote:
> 
> Hi,
> 
> I've been working on getting Insight working with Tcl/Tk 8.3
> and here is my first patch on the matter.
> 
> More to follow (but I'm trying to make as few changes as possible).
> 
> This patch addresses minor C API changes in Tcl.
> 

Whatever you say Ian.

We must ask Andrew to add you to the write after approval list (at least
for gdbtk files) or this will be a nightmare (one of us will have to
check in all of your patches, one by one).

Andrew, can we add Ian (one of the Source Navigator maintainers) to our
list of write after approval?

Thanks,
Fernando



> ChangeLog:
> 
> 2001-05-14  Ian Roxborough <irox@redhat.com>
> 
>         * generic/gdbtk-hooks.c (x_event): Minor
>         API changes with Tcl version update.
>         Use the Tcl_ObjGetVar2 call with Tcl8.3.
>         (gdbtk_trace_find): Use Tcl_GlobalEvalObj
>         call with Tcl8.3.
> 
> Index: generic/gdbtk-hooks.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
> retrieving revision 1.13
> diff -u -r1.13 gdbtk-hooks.c
> --- gdbtk-hooks.c       2001/05/10 22:34:54     1.13
> +++ gdbtk-hooks.c       2001/05/14 23:49:42
> @@ -462,7 +462,7 @@
>        int val;
>        if (varname == NULL)
>         {
> -#if TCL_MAJOR_VERSION == 8 && TCL_MINOR_VERSION < 1
> +#if TCL_MAJOR_VERSION == 8 && (TCL_MINOR_VERSION < 1 || TCL_MINOR_VERSION > 2)
>           Tcl_Obj *varnamestrobj = Tcl_NewStringObj ("download_cancel_ok", -1);
>           varname = Tcl_ObjGetVar2 (gdbtk_interp, varnamestrobj, NULL, TCL_GLOBAL_ONLY);
>  #else
> @@ -733,7 +733,7 @@
>                         Tcl_NewStringObj ("gdbtk_tcl_trace_find_hook", -1));
>    Tcl_ListObjAppendElement (gdbtk_interp, cmdObj, Tcl_NewStringObj (arg, -1));
>    Tcl_ListObjAppendElement (gdbtk_interp, cmdObj, Tcl_NewIntObj (from_tty));
> -#if TCL_MAJOR_VERSION == 8 && TCL_MINOR_VERSION < 1
> +#if TCL_MAJOR_VERSION == 8 && (TCL_MINOR_VERSION < 1 || TCL_MINOR_VERSION > 2)
>    if (Tcl_GlobalEvalObj (gdbtk_interp, cmdObj) != TCL_OK)
>      report_error ();
>  #else
> 
> --
> What would Jenna Bush do?

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

Re: [PATCH] prep for Tcl/Tk 8.3 upgrade

[Andrew Cagney]

> We must ask Andrew to add you to the write after approval list (at least
> for gdbtk files) or this will be a nightmare (one of us will have to
> check in all of your patches, one by one).
> 
> Andrew, can we add Ian (one of the Source Navigator maintainers) to our
> list of write after approval?


To be added to the GDB maintainers file, Ian would need to post a 
reasonable patch for GDB to the GDB list.

There was a proposal to create an Insight maintainers file co-ordinated 
by the Insight maintainers.  Right now things are a little wierd.  I'm 
not responsible for Insight but that isn't clear since Insight is listed 
in the GDB MAINTAINERS file.

	Andrew

Re: [PATCH] prep for Tcl/Tk 8.3 upgrade

[Keith Seitz]

On Wed, 16 May 2001, Andrew Cagney wrote:

> There was a proposal to create an Insight maintainers file co-ordinated
> by the Insight maintainers.  Right now things are a little wierd.  I'm
> not responsible for Insight but that isn't clear since Insight is listed
> in the GDB MAINTAINERS file.

Yes, I was working on this at one time (and forgot all about it). If it is
agreeable to everyone else, I will remove most of the Insight/gdbtk
references in gdb/MAINTAINERS and move them to gdb/gdbtk/MAINTAINERS.

The idea was to largely keep the same policies. Everyone with write
authority in gdb would automatically have write-after-approval in gdbtk.

Let me know.
Keith

Re: [PATCH] prep for Tcl/Tk 8.3 upgrade

[Fernando Nasser]

Keith Seitz wrote:
> 
> On Wed, 16 May 2001, Andrew Cagney wrote:
> 
> > There was a proposal to create an Insight maintainers file co-ordinated
> > by the Insight maintainers.  Right now things are a little wierd.  I'm
> > not responsible for Insight but that isn't clear since Insight is listed
> > in the GDB MAINTAINERS file.
> 
> Yes, I was working on this at one time (and forgot all about it). If it is
> agreeable to everyone else, I will remove most of the Insight/gdbtk
> references in gdb/MAINTAINERS and move them to gdb/gdbtk/MAINTAINERS.
> 
> The idea was to largely keep the same policies. Everyone with write
> authority in gdb would automatically have write-after-approval in gdbtk.
> 
> Let me know.
> Keith

I agree.


-- 
Fernando Nasser
Red Hat Canada Ltd.