Re: [PATCH] prep for Tcl/Tk 8.3 upgrade

[Fernando Nasser <fnasser@redhat.com>]

Ian Roxborough wrote:
> 
> Hi,
> 
> I've been working on getting Insight working with Tcl/Tk 8.3
> and here is my first patch on the matter.
> 
> More to follow (but I'm trying to make as few changes as possible).
> 
> This patch addresses minor C API changes in Tcl.
> 

Whatever you say Ian.

We must ask Andrew to add you to the write after approval list (at least
for gdbtk files) or this will be a nightmare (one of us will have to
check in all of your patches, one by one).

Andrew, can we add Ian (one of the Source Navigator maintainers) to our
list of write after approval?

Thanks,
Fernando



> ChangeLog:
> 
> 2001-05-14  Ian Roxborough <irox@redhat.com>
> 
>         * generic/gdbtk-hooks.c (x_event): Minor
>         API changes with Tcl version update.
>         Use the Tcl_ObjGetVar2 call with Tcl8.3.
>         (gdbtk_trace_find): Use Tcl_GlobalEvalObj
>         call with Tcl8.3.
> 
> Index: generic/gdbtk-hooks.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
> retrieving revision 1.13
> diff -u -r1.13 gdbtk-hooks.c
> --- gdbtk-hooks.c       2001/05/10 22:34:54     1.13
> +++ gdbtk-hooks.c       2001/05/14 23:49:42
> @@ -462,7 +462,7 @@
>        int val;
>        if (varname == NULL)
>         {
> -#if TCL_MAJOR_VERSION == 8 && TCL_MINOR_VERSION < 1
> +#if TCL_MAJOR_VERSION == 8 && (TCL_MINOR_VERSION < 1 || TCL_MINOR_VERSION > 2)
>           Tcl_Obj *varnamestrobj = Tcl_NewStringObj ("download_cancel_ok", -1);
>           varname = Tcl_ObjGetVar2 (gdbtk_interp, varnamestrobj, NULL, TCL_GLOBAL_ONLY);
>  #else
> @@ -733,7 +733,7 @@
>                         Tcl_NewStringObj ("gdbtk_tcl_trace_find_hook", -1));
>    Tcl_ListObjAppendElement (gdbtk_interp, cmdObj, Tcl_NewStringObj (arg, -1));
>    Tcl_ListObjAppendElement (gdbtk_interp, cmdObj, Tcl_NewIntObj (from_tty));
> -#if TCL_MAJOR_VERSION == 8 && TCL_MINOR_VERSION < 1
> +#if TCL_MAJOR_VERSION == 8 && (TCL_MINOR_VERSION < 1 || TCL_MINOR_VERSION > 2)
>    if (Tcl_GlobalEvalObj (gdbtk_interp, cmdObj) != TCL_OK)
>      report_error ();
>  #else
> 
> --
> What would Jenna Bush do?

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9