Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: tromey@redhat.com
Cc: gdb@sourceware.org
Subject: Re: Solibs and objfile BFD ownership
Date: Fri, 21 Aug 2009 18:04:00 -0000	[thread overview]
Message-ID: <8ac60eac0908211057n2acaa368tf20acbfad71a1ae@mail.gmail.com> (raw)
In-Reply-To: <m3bpm92hyo.fsf@fleche.redhat.com>

On Fri, Aug 21, 2009 at 10:29 AM, Tom Tromey<tromey@redhat.com> wrote:

> This is ok.   Thanks.

So committed.

> Paul> +   gdb_assert (*p_refcount == 1 || *p_refcount == 2);
>
> This assertion is a bit strange, but I suppose it is harmless.   If we
> ever want more sharing, we can always just remove it.   In the meantime I
> suppose it is checking that we don't over-share somehow.

The assertion was intended to catch somebody else in GDB using bfd_usrdata
for some other purpose (in a way I didn't find).

I think it's safe to leave it in for now.

Thanks,
-- 
Paul Pluzhnikov


      reply	other threads:[~2009-08-21 17:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-28 15:40 Daniel Jacobowitz
2009-07-29 23:56 ` Paul Pluzhnikov
2009-07-30 16:16   ` Tom Tromey
2009-08-04  0:50     ` Paul Pluzhnikov
2009-08-04 14:53       ` Daniel Jacobowitz
2009-08-04 17:37         ` Paul Pluzhnikov
2009-08-04 18:40           ` Daniel Jacobowitz
2009-08-04 18:47             ` Paul Pluzhnikov
2009-08-18  5:56               ` Paul Pluzhnikov
2009-08-19 22:29                 ` Tom Tromey
2009-08-20  1:50                   ` Paul Pluzhnikov
2009-08-21 17:32                     ` Tom Tromey
2009-08-21 18:04                       ` Paul Pluzhnikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ac60eac0908211057n2acaa368tf20acbfad71a1ae@mail.gmail.com \
    --to=ppluzhnikov@google.com \
    --cc=gdb@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox