From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13169 invoked by alias); 21 Aug 2009 17:57:43 -0000 Received: (qmail 13161 invoked by uid 22791); 21 Aug 2009 17:57:42 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Aug 2009 17:57:36 +0000 Received: from spaceape8.eur.corp.google.com (spaceape8.eur.corp.google.com [172.28.16.142]) by smtp-out.google.com with ESMTP id n7LHvWFr019897 for ; Fri, 21 Aug 2009 10:57:33 -0700 Received: from pxi29 (pxi29.prod.google.com [10.243.27.29]) by spaceape8.eur.corp.google.com with ESMTP id n7LHvTWE001889 for ; Fri, 21 Aug 2009 10:57:30 -0700 Received: by pxi29 with SMTP id 29so4146108pxi.30 for ; Fri, 21 Aug 2009 10:57:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.204.4 with SMTP id b4mr799819rvg.80.1250877447779; Fri, 21 Aug 2009 10:57:27 -0700 (PDT) In-Reply-To: References: <20090728154001.GA19451@caradoc.them.org> <8ac60eac0908031749y59867374wa451d2f504483390@mail.gmail.com> <20090804145318.GA31664@caradoc.them.org> <8ac60eac0908041037q46b447d9n7b539ab53d7ce1ea@mail.gmail.com> <20090804184000.GA14873@caradoc.them.org> <8ac60eac0908041147m17f3f337g3ea15696dc0a3170@mail.gmail.com> <8ac60eac0908171544r6d1eac67lcaedb388b525c5@mail.gmail.com> <8ac60eac0908191656o6c7c876cp503a3b6973ea090b@mail.gmail.com> Date: Fri, 21 Aug 2009 18:04:00 -0000 Message-ID: <8ac60eac0908211057n2acaa368tf20acbfad71a1ae@mail.gmail.com> Subject: Re: Solibs and objfile BFD ownership From: Paul Pluzhnikov To: tromey@redhat.com Cc: gdb@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00213.txt.bz2 On Fri, Aug 21, 2009 at 10:29 AM, Tom Tromey wrote: > This is ok. Thanks. So committed. > Paul> + gdb_assert (*p_refcount == 1 || *p_refcount == 2); > > This assertion is a bit strange, but I suppose it is harmless. If we > ever want more sharing, we can always just remove it. In the meantime I > suppose it is checking that we don't over-share somehow. The assertion was intended to catch somebody else in GDB using bfd_usrdata for some other purpose (in a way I didn't find). I think it's safe to leave it in for now. Thanks, -- Paul Pluzhnikov