From: Daniel Jacobowitz <drow@false.org>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: tromey@redhat.com, gdb@sourceware.org
Subject: Re: Solibs and objfile BFD ownership
Date: Tue, 04 Aug 2009 18:40:00 -0000 [thread overview]
Message-ID: <20090804184000.GA14873@caradoc.them.org> (raw)
In-Reply-To: <8ac60eac0908041037q46b447d9n7b539ab53d7ce1ea@mail.gmail.com>
On Tue, Aug 04, 2009 at 10:37:24AM -0700, Paul Pluzhnikov wrote:
> On Tue, Aug 4, 2009 at 7:53 AM, Daniel Jacobowitz<drow@false.org> wrote:
>
> > A comment somewhere about the usage of the usrdata field would be
> > nice. Â I gather that NULL and 1 behave the same?
>
> Yes. I added comment to gdb_bfd_unref.
> Updated patch attached. Tested on Linux/x86_64 with no new failures.
>
> Daniel, could you confirm that this fixes the ARM failures?
Yes - looks much better with this patch!
> 2009-08-04 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * objfiles.h (OBJF_KEEPBFD): Delete.
> (gdb_bfd_unref): New prototype.
> * objfiles.c (gdb_bfd_unref): New function.
> (free_objfile): Call gdb_bfd_unref.
> * solib.c (free_so): Likewise.
> (symbol_add_stub): Set refcount.
OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-08-04 18:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 15:40 Daniel Jacobowitz
2009-07-29 23:56 ` Paul Pluzhnikov
2009-07-30 16:16 ` Tom Tromey
2009-08-04 0:50 ` Paul Pluzhnikov
2009-08-04 14:53 ` Daniel Jacobowitz
2009-08-04 17:37 ` Paul Pluzhnikov
2009-08-04 18:40 ` Daniel Jacobowitz [this message]
2009-08-04 18:47 ` Paul Pluzhnikov
2009-08-18 5:56 ` Paul Pluzhnikov
2009-08-19 22:29 ` Tom Tromey
2009-08-20 1:50 ` Paul Pluzhnikov
2009-08-21 17:32 ` Tom Tromey
2009-08-21 18:04 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804184000.GA14873@caradoc.them.org \
--to=drow@false.org \
--cc=gdb@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox