From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30484 invoked by alias); 4 Aug 2009 18:40:14 -0000 Received: (qmail 30471 invoked by uid 22791); 4 Aug 2009 18:40:12 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Aug 2009 18:40:05 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0523710ACE; Tue, 4 Aug 2009 18:40:03 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id C15D9108C6; Tue, 4 Aug 2009 18:40:02 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1MYOvY-0003sx-TI; Tue, 04 Aug 2009 14:40:00 -0400 Date: Tue, 04 Aug 2009 18:40:00 -0000 From: Daniel Jacobowitz To: Paul Pluzhnikov Cc: tromey@redhat.com, gdb@sourceware.org Subject: Re: Solibs and objfile BFD ownership Message-ID: <20090804184000.GA14873@caradoc.them.org> Mail-Followup-To: Paul Pluzhnikov , tromey@redhat.com, gdb@sourceware.org References: <20090728154001.GA19451@caradoc.them.org> <8ac60eac0907291656v13f568ebw4f3a2b9bb7c7223d@mail.gmail.com> <8ac60eac0908031749y59867374wa451d2f504483390@mail.gmail.com> <20090804145318.GA31664@caradoc.them.org> <8ac60eac0908041037q46b447d9n7b539ab53d7ce1ea@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8ac60eac0908041037q46b447d9n7b539ab53d7ce1ea@mail.gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00019.txt.bz2 On Tue, Aug 04, 2009 at 10:37:24AM -0700, Paul Pluzhnikov wrote: > On Tue, Aug 4, 2009 at 7:53 AM, Daniel Jacobowitz wrote: > > > A comment somewhere about the usage of the usrdata field would be > > nice.  I gather that NULL and 1 behave the same? > > Yes. I added comment to gdb_bfd_unref. > Updated patch attached. Tested on Linux/x86_64 with no new failures. > > Daniel, could you confirm that this fixes the ARM failures? Yes - looks much better with this patch! > 2009-08-04 Paul Pluzhnikov > > * objfiles.h (OBJF_KEEPBFD): Delete. > (gdb_bfd_unref): New prototype. > * objfiles.c (gdb_bfd_unref): New function. > (free_objfile): Call gdb_bfd_unref. > * solib.c (free_so): Likewise. > (symbol_add_stub): Set refcount. OK. -- Daniel Jacobowitz CodeSourcery