Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Gary Benson <gbenson@redhat.com>
Cc: Mike Frysinger <vapier@gentoo.org>, gdb@sourceware.org
Subject: Re: ChangeLogs in commit messages
Date: Thu, 14 Aug 2014 16:22:00 -0000	[thread overview]
Message-ID: <87tx5frqhn.fsf@br87z6lw.de.ibm.com> (raw)
In-Reply-To: <20140814131206.GA12746@blade.nx> (Gary Benson's message of "Thu,	14 Aug 2014 14:12:06 +0100")

On Thu, Aug 14 2014, Gary Benson wrote:

> Mike Frysinger wrote:
>> On Thu 14 Aug 2014 09:32:31 Gary Benson wrote:
>> > What are people's preferences here?  My preference is #1, but I
>> > could live with #3.  If we come to some kind of concensus on this
>> > I'll update the wiki to reflect this.
>> 
>> (4) -- none of the above.  the ChangeLog files contain the same
>> data, so the commit messages should contain useful details.
>> i.e. the same content you used when you posted to the mailing list.
>
> Do you mean #4 (changelog entries with no path/author-date) or are you
> proposing new option #5 (no changelog in the commit message at all)?
> #5 would suit me too.

Since Mike obviously meant #5, I tend to agree.  At least as long as we
keep ChangeLog files in git, rather than extracting them with some
automatism from the git commit messages, e.g., as suggested here:

  https://sourceware.org/ml/gdb-patches/2014-01/msg00578.html

Let's assume we consistently do #5, so no ChangeLog entries in the
commit messages, but just in the ChangeLog files.  Then, to see them
again in a "git log", we can still do something like this:

  git log -U0 gdb/ChangeLog --since='1 week ago'

On the other hand, it's more difficult to *suppress* the existing
ChangeLogs in a "git log".


  parent reply	other threads:[~2014-08-14 16:22 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14  8:32 Gary Benson
2014-08-14 12:52 ` Joel Brobecker
2014-08-14 13:15   ` Gary Benson
2014-08-14 13:25     ` Joel Brobecker
2014-08-14 15:22     ` Eli Zaretskii
2014-08-15  8:05       ` Gary Benson
2014-08-15  8:41         ` Eli Zaretskii
2014-08-15 11:45           ` Andreas Schwab
2014-09-03 20:54   ` Sergio Durigan Junior
2014-09-03 21:22     ` Sergio Durigan Junior
2014-09-03 22:18       ` Andreas Schwab
2014-09-04  9:06         ` Gary Benson
2014-09-04 14:23           ` Sergio Durigan Junior
2014-09-04 16:08             ` Doug Evans
2014-09-04 17:36               ` Gary Benson
2014-09-05 10:13                 ` Gary Benson
2014-09-05 16:43                   ` Doug Evans
2014-09-08  9:50                     ` Gary Benson
2014-09-08 13:08                       ` James Hogan
2014-09-08 13:21                         ` James Hogan
2014-09-08 13:24                         ` Joel Brobecker
2014-09-08 15:31                           ` Gary Benson
2014-09-09  8:51                           ` James Hogan
2014-09-09 16:25                             ` Doug Evans
     [not found]   ` <54102ED8.7060307@redhat.com>
2014-09-10 16:12     ` Doug Evans
2014-09-10 16:28       ` Joel Brobecker
2014-09-15 10:30         ` Gary Benson
2014-09-15 12:45           ` Joel Brobecker
2014-09-15 15:30           ` Doug Evans
2014-09-15 16:05             ` Joel Brobecker
2014-09-15 17:47               ` Doug Evans
2014-09-16  9:31                 ` Gary Benson
2014-09-16 15:50                   ` Doug Evans
     [not found]                     ` <0CEE46EB9C50E44486A861D738D3E20645F67101@rsex2.realsil.com.cn>
2014-10-03 18:22                       ` GDB bugs Pedro Alves
2014-08-14 12:57 ` ChangeLogs in commit messages Mike Frysinger
2014-08-14 13:12   ` Gary Benson
2014-08-14 13:29     ` Joel Brobecker
2014-08-14 13:39       ` Andreas Schwab
2014-08-14 13:48         ` Joel Brobecker
2014-08-14 13:57           ` Andreas Schwab
2014-08-14 14:22             ` Joel Brobecker
2014-08-14 14:45               ` Andreas Schwab
2014-08-14 15:01                 ` Joel Brobecker
2014-08-14 15:13                   ` Andreas Schwab
2014-08-14 15:22                     ` Joel Brobecker
2014-08-14 15:44                       ` Andreas Schwab
2014-08-14 15:49                         ` Joel Brobecker
2014-08-14 19:04       ` Sergio Durigan Junior
2014-08-15  8:48       ` Gary Benson
2014-08-15 12:11         ` Joel Brobecker
2014-08-15 13:09           ` Gary Benson
2014-08-15 13:28             ` Joel Brobecker
2014-08-15 15:02               ` Gary Benson
2014-08-15 15:27                 ` Andreas Arnez
2014-08-15 16:08                 ` Joel Brobecker
2014-08-18  8:31                   ` Gary Benson
2014-08-18 14:54                     ` Doug Evans
2014-08-18 15:05                       ` Joel Brobecker
2014-08-18 15:27                         ` Gary Benson
2014-08-20 12:20                           ` Gary Benson
2014-08-14 16:22     ` Andreas Arnez [this message]
2014-08-14 13:23   ` Mike Frysinger
2014-08-14 13:36 ` Siva Chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx5frqhn.fsf@br87z6lw.de.ibm.com \
    --to=arnez@linux.vnet.ibm.com \
    --cc=gbenson@redhat.com \
    --cc=gdb@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox