Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Gary Benson <gbenson@redhat.com>,
	Andreas Schwab <schwab@linux-m68k.org>,
		Joel Brobecker <brobecker@adacore.com>, gdb <gdb@sourceware.org>,
		Andreas Arnez <arnez@linux.vnet.ibm.com>
Subject: Re: ChangeLogs in commit messages
Date: Thu, 04 Sep 2014 16:08:00 -0000	[thread overview]
Message-ID: <CADPb22ShAUeyzwpaLnTO4+ob=S1P2PyqD=4oN94fEx4ikNKUAw@mail.gmail.com> (raw)
In-Reply-To: <87y4tzcvny.fsf@redhat.com>

On Thu, Sep 4, 2014 at 7:22 AM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> On Thursday, September 04 2014, Gary Benson wrote:
>
>>> There is no such thing as a "push date".  What you see is the author
>>> date and the committer date.  But both are set during the local
>>> commit, and are unrelated to the point of time of pushing the
>>> commits to the remote repository.
>>
>> Yeah, in git no file (object) is modified when you push or pull
>> commits, they're just copied from one place to another.
>
> Yeah, sorry for not being fluent in git's parlance.
>
>> The committer date on the commit you mentioned is likely the time
>> I updated the ChangeLog prior to pushing, so that date will be the
>> "push date", but that's not guaranteed to be the case for all
>> commits.
>
> Right.  Anyway, I still consider it is valid to include this info
> (author and date) in the commit message.

For reference sake, what started this for me
is noticing git blame shows the author date by default.

Not picking on Gary of course, his patch is just
why I noticed this.
If I do a git blame of server.c I see patch 860789c7 with a date
of 2014-08-08.  That's three weeks before it was pushed upstream.
Bleah.  I'd really like to be able to do a git blame and have what
I see be useful, including the date.
The author date is basically useless to me.

[I realize neither author nor commit dates are the so-called push date,
but I'm guessing the commit date is generally reasonably
close to the date the patch is pushed upstream.
If not ... yikes.]

I realize any changes to what goes into the commit log
won't help solve this of course.  But that's what
started the discussion for me.


  reply	other threads:[~2014-09-04 16:08 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14  8:32 Gary Benson
2014-08-14 12:52 ` Joel Brobecker
2014-08-14 13:15   ` Gary Benson
2014-08-14 13:25     ` Joel Brobecker
2014-08-14 15:22     ` Eli Zaretskii
2014-08-15  8:05       ` Gary Benson
2014-08-15  8:41         ` Eli Zaretskii
2014-08-15 11:45           ` Andreas Schwab
2014-09-03 20:54   ` Sergio Durigan Junior
2014-09-03 21:22     ` Sergio Durigan Junior
2014-09-03 22:18       ` Andreas Schwab
2014-09-04  9:06         ` Gary Benson
2014-09-04 14:23           ` Sergio Durigan Junior
2014-09-04 16:08             ` Doug Evans [this message]
2014-09-04 17:36               ` Gary Benson
2014-09-05 10:13                 ` Gary Benson
2014-09-05 16:43                   ` Doug Evans
2014-09-08  9:50                     ` Gary Benson
2014-09-08 13:08                       ` James Hogan
2014-09-08 13:21                         ` James Hogan
2014-09-08 13:24                         ` Joel Brobecker
2014-09-08 15:31                           ` Gary Benson
2014-09-09  8:51                           ` James Hogan
2014-09-09 16:25                             ` Doug Evans
     [not found]   ` <54102ED8.7060307@redhat.com>
2014-09-10 16:12     ` Doug Evans
2014-09-10 16:28       ` Joel Brobecker
2014-09-15 10:30         ` Gary Benson
2014-09-15 12:45           ` Joel Brobecker
2014-09-15 15:30           ` Doug Evans
2014-09-15 16:05             ` Joel Brobecker
2014-09-15 17:47               ` Doug Evans
2014-09-16  9:31                 ` Gary Benson
2014-09-16 15:50                   ` Doug Evans
     [not found]                     ` <0CEE46EB9C50E44486A861D738D3E20645F67101@rsex2.realsil.com.cn>
2014-10-03 18:22                       ` GDB bugs Pedro Alves
2014-08-14 12:57 ` ChangeLogs in commit messages Mike Frysinger
2014-08-14 13:12   ` Gary Benson
2014-08-14 13:29     ` Joel Brobecker
2014-08-14 13:39       ` Andreas Schwab
2014-08-14 13:48         ` Joel Brobecker
2014-08-14 13:57           ` Andreas Schwab
2014-08-14 14:22             ` Joel Brobecker
2014-08-14 14:45               ` Andreas Schwab
2014-08-14 15:01                 ` Joel Brobecker
2014-08-14 15:13                   ` Andreas Schwab
2014-08-14 15:22                     ` Joel Brobecker
2014-08-14 15:44                       ` Andreas Schwab
2014-08-14 15:49                         ` Joel Brobecker
2014-08-14 19:04       ` Sergio Durigan Junior
2014-08-15  8:48       ` Gary Benson
2014-08-15 12:11         ` Joel Brobecker
2014-08-15 13:09           ` Gary Benson
2014-08-15 13:28             ` Joel Brobecker
2014-08-15 15:02               ` Gary Benson
2014-08-15 15:27                 ` Andreas Arnez
2014-08-15 16:08                 ` Joel Brobecker
2014-08-18  8:31                   ` Gary Benson
2014-08-18 14:54                     ` Doug Evans
2014-08-18 15:05                       ` Joel Brobecker
2014-08-18 15:27                         ` Gary Benson
2014-08-20 12:20                           ` Gary Benson
2014-08-14 16:22     ` Andreas Arnez
2014-08-14 13:23   ` Mike Frysinger
2014-08-14 13:36 ` Siva Chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22ShAUeyzwpaLnTO4+ob=S1P2PyqD=4oN94fEx4ikNKUAw@mail.gmail.com' \
    --to=dje@google.com \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gbenson@redhat.com \
    --cc=gdb@sourceware.org \
    --cc=schwab@linux-m68k.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox