From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28809 invoked by alias); 14 Aug 2014 16:22:10 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 28797 invoked by uid 89); 14 Aug 2014 16:22:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp10.uk.ibm.com Received: from e06smtp10.uk.ibm.com (HELO e06smtp10.uk.ibm.com) (195.75.94.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 14 Aug 2014 16:22:03 +0000 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 14 Aug 2014 17:21:59 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 14 Aug 2014 17:21:57 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 76F1B17D8056 for ; Thu, 14 Aug 2014 17:23:46 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s7EGLvh822347914 for ; Thu, 14 Aug 2014 16:21:57 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s7EGLuuD001446 for ; Thu, 14 Aug 2014 10:21:56 -0600 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-196.boeblingen.de.ibm.com [9.152.212.196]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s7EGLu5I001443; Thu, 14 Aug 2014 10:21:56 -0600 From: Andreas Arnez To: Gary Benson Cc: Mike Frysinger , gdb@sourceware.org Subject: Re: ChangeLogs in commit messages References: <20140814083231.GA6283@blade.nx> <6036430.RnprRWgZmF@vapier> <20140814131206.GA12746@blade.nx> Date: Thu, 14 Aug 2014 16:22:00 -0000 In-Reply-To: <20140814131206.GA12746@blade.nx> (Gary Benson's message of "Thu, 14 Aug 2014 14:12:06 +0100") Message-ID: <87tx5frqhn.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14081416-4966-0000-0000-0000010729D2 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00040.txt.bz2 On Thu, Aug 14 2014, Gary Benson wrote: > Mike Frysinger wrote: >> On Thu 14 Aug 2014 09:32:31 Gary Benson wrote: >> > What are people's preferences here? My preference is #1, but I >> > could live with #3. If we come to some kind of concensus on this >> > I'll update the wiki to reflect this. >> >> (4) -- none of the above. the ChangeLog files contain the same >> data, so the commit messages should contain useful details. >> i.e. the same content you used when you posted to the mailing list. > > Do you mean #4 (changelog entries with no path/author-date) or are you > proposing new option #5 (no changelog in the commit message at all)? > #5 would suit me too. Since Mike obviously meant #5, I tend to agree. At least as long as we keep ChangeLog files in git, rather than extracting them with some automatism from the git commit messages, e.g., as suggested here: https://sourceware.org/ml/gdb-patches/2014-01/msg00578.html Let's assume we consistently do #5, so no ChangeLog entries in the commit messages, but just in the ChangeLog files. Then, to see them again in a "git log", we can still do something like this: git log -U0 gdb/ChangeLog --since='1 week ago' On the other hand, it's more difficult to *suppress* the existing ChangeLogs in a "git log".