Problem calling functions within gdb (version 7.5)

Problem calling functions within gdb (version 7.5)

[Saurabh T]

Here's a simple C++ example:
 
#include <stdio.h>
 
void fn(int n, const double (*x)[3])
{
  for (int i=0; i < n; i++)
    printf("%g %g %g\n", x[i][0], x[i][1], x[i][2]);
}
 
void fn2(int *k)
{ printf("%d\n", *k); }
 
int main()
{
  int n = 3;
  const double x[3][3] = {{1, 2, 3}, {3, 4, 5}, {5, 6, 7}};
  fn(3, x);
  int *k = &n;
  fn2(k);
  return 0;
}
 
In gdb, if you put a breakpoint at the return 0 line, run until there, and say:
 
1. call fn(3, x)
gdb says: Cannot resolve function fn to any overloaded instance
This used to work with gdb 7.2. The function signature completely matches the arguments so I dont know what it's complaining about.
 
2. print k
Let's say this prints 0x7ffb24
call fn2(0x7ffb24)
gdb again says: Cannot resolve function fn2 to any overloaded instance
This also used to work with gdb 7.2. Here I can understand if promoting ints to arbitrary pointers is no longer supported.
 
Any thoughts as to whether these are bugs, or how I can get the behaviour I want at least wrt case 1?
 
Thanks. 		 	   		  
From gdb-return-42043-listarch-gdb=sources.redhat.com@sourceware.org Thu Apr 25 06:41:31 2013
Return-Path: <gdb-return-42043-listarch-gdb=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb@sources.redhat.com
Received: (qmail 4152 invoked by alias); 25 Apr 2013 06:41:30 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Delivered-To: mailing list gdb@sourceware.org
Received: (qmail 4141 invoked by uid 89); 25 Apr 2013 06:41:30 -0000
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1
Received: from mail-bk0-f54.google.com (HELO mail-bk0-f54.google.com) (209.85.214.54)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 25 Apr 2013 06:41:29 +0000
Received: by mail-bk0-f54.google.com with SMTP id q11so1103858bkw.27        for <gdb@sourceware.org>; Wed, 24 Apr 2013 23:41:27 -0700 (PDT)
X-Received: by 10.205.75.3 with SMTP id yy3mr14279404bkb.80.1366872087083; Wed, 24 Apr 2013 23:41:27 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.205.83.204 with HTTP; Wed, 24 Apr 2013 23:40:46 -0700 (PDT)
From: Hui Zhu <teawater@gmail.com>
Date: Thu, 25 Apr 2013 06:41:00 -0000
Message-ID: <CANFwon0v3pwvC_iJbEnzVp4ZB-B+zphAg-C+hrQqF153P+M_ag@mail.gmail.com>
Subject: New format of 7.6 branch gdb/ChangeLog?
To: gdb@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
X-SW-Source: 2013-04/txt/msg00078.txt.bz2
Content-length: 490

2013-04-24  Hui Zhu  <hui@codesourcery.com>

	PR gdb/15165

	* breakpoint.c (dprintf_print_recreate): New.
	(save_breakpoints): Let it not save dprintf commands.
	(initialize_breakpoint_ops): Set dprintf_print_recreate.

gdb/
2013-04-19  Vladimir Kargov <kargov@gmail.com>
	    Pedro Alves  <palves@redhat.com>

	* i387-tdep.c (i387_print_float_info): Use gdb_byte for pointer to
	value contents.

"gdb/"
Is this a new format of Changelog?  Do I need move changelog after it?

Thanks,
Hui

Re: Problem calling functions within gdb (version 7.5)

[Phil Muldoon]

On 24/04/13 22:30, Saurabh T wrote:
> Here's a simple C++ example:

> 1. call fn(3, x)
> 2. print k
> Let's say this prints 0x7ffb24
> call fn2(0x7ffb24)
> gdb again says: Cannot resolve function fn2 to any overloaded instance
> This also used to work with gdb 7.2. Here I can understand if promoting ints to arbitrary pointers is no longer supported.

[pmuldoon@localhost build]$ gdb --version
GNU gdb (GDB) Fedora (7.5.1-37.fc18)
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.


(gdb) b 19
Breakpoint 1 at 0x4006bc: file /home/pmuldoon/pr.c, line 19.
(gdb) r
Starting program: /home/pmuldoon/pr 
1 2 3
3 4 5
5 6 7
3

Breakpoint 1, main () at /home/pmuldoon/pr.c:19
19	  return 0;
(gdb) call fn(3,x)
1 2 3
3 4 5
5 6 7
(gdb) call fn2(k)
3
(gdb) p k
$1 = (int *) 0x7fffffffe064
(gdb) call fn2(0x7fffffffe064)
3

So it works with my installed GDB.  What architecture, and what minor
version of GDB are you using (ie 7.5.x)?  How did you compile the
binary?  I did:

gcc  -std=c99 ~/build/pr.c -o ~/build/pr -O0 -g3

Cheers,

Phil

Re: Problem calling functions within gdb (version 7.5)

[Tom Tromey]

>>>>> "Saurabh" == Saurabh T <saurabh@hotmail.com> writes:

Saurabh> 1. call fn(3, x)
Saurabh> gdb says: Cannot resolve function fn to any overloaded instance
Saurabh> This used to work with gdb 7.2. The function signature completely
Saurabh> matches the arguments so I dont know what it's complaining about.

Please file a bug report.

Saurabh> 2. print k
Saurabh> Let's say this prints 0x7ffb24
Saurabh> call fn2(0x7ffb24)
Saurabh> gdb again says: Cannot resolve function fn2 to any overloaded instance
Saurabh> This also used to work with gdb 7.2. Here I can understand if
Saurabh> promoting ints to arbitrary pointers is no longer supported.

I was under the impression that we allowed this again, but it fails for
me too.  Please file another bug for this one.

Saurabh> Any thoughts as to whether these are bugs, or how I can get the
Saurabh> behaviour I want at least wrt case 1?

Not offhand.

Tom

Re: Problem calling functions within gdb (version 7.5)

[Tom Tromey]

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> So it works with my installed GDB.  What architecture, and what minor
Phil> version of GDB are you using (ie 7.5.x)?  How did you compile the
Phil> binary?  I did:

Phil> gcc  -std=c99 ~/build/pr.c -o ~/build/pr -O0 -g3

It fails if you use g++ here.

Tom

RE: Problem calling functions within gdb (version 7.5)

[Saurabh T]

> From: tromey@redhat.com
>
> Saurabh> 1. call fn(3, x)
> Saurabh> gdb says: Cannot resolve function fn to any overloaded instance
> Saurabh> This used to work with gdb 7.2. The function signature completely
> Saurabh> matches the arguments so I dont know what it's complaining about.
>
> Please file a bug report.

Done: http://sourceware.org/bugzilla/show_bug.cgi?id=15398

>
> Saurabh> 2. print k
> Saurabh> Let's say this prints 0x7ffb24
> Saurabh> call fn2(0x7ffb24)
> Saurabh> gdb again says: Cannot resolve function fn2 to any overloaded instance
> Saurabh> This also used to work with gdb 7.2. Here I can understand if
> Saurabh> promoting ints to arbitrary pointers is no longer supported.
>
> I was under the impression that we allowed this again, but it fails for
> me too. Please file another bug for this one.

Done: http://sourceware.org/bugzilla/show_bug.cgi?id=15399

Thank you. 		 	   		  
From gdb-return-42054-listarch-gdb=sources.redhat.com@sourceware.org Thu Apr 25 15:09:35 2013
Return-Path: <gdb-return-42054-listarch-gdb=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb@sources.redhat.com
Received: (qmail 7491 invoked by alias); 25 Apr 2013 15:09:35 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Delivered-To: mailing list gdb@sourceware.org
Received: (qmail 7475 invoked by uid 89); 25 Apr 2013 15:09:34 -0000
X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 25 Apr 2013 15:09:34 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3PF9WrI025987	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits%6 verify=OK);	Thu, 25 Apr 2013 11:09:32 -0400
Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3PF9V69020851	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits%6 verify=NO);	Thu, 25 Apr 2013 11:09:32 -0400
Message-ID: <5179472B.5020107@redhat.com>
Date: Thu, 25 Apr 2013 15:09:00 -0000
From: Keith Seitz <keiths@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5
MIME-Version: 1.0
To: Saurabh T <saurabh@hotmail.com>
CC: "gdb@sourceware.org" <gdb@sourceware.org>
Subject: Re: Problem calling functions within gdb (version 7.5)
References: <DUB123-W3379C1D5569CB0664A9923B1B50@phx.gbl>,<87r4hykai1.fsf@fleche.redhat.com> <DUB123-W1189571D83329779F4BA17B1B60@phx.gbl>
In-Reply-To: <DUB123-W1189571D83329779F4BA17B1B60@phx.gbl>
Content-Type: text/plain; charset=windows-1251; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-04/txt/msg00089.txt.bz2
Content-length: 1387

On 04/25/2013 07:24 AM, Saurabh T wrote:
>> From: tromey@redhat.com
>>
>> Saurabh> 1. call fn(3, x)
>> Saurabh> gdb says: Cannot resolve function fn to any overloaded instance
>> Saurabh> This used to work with gdb 7.2. The function signature completely
>> Saurabh> matches the arguments so I dont know what it's complaining about.
>>
>> Please file a bug report.
>
> Done: http://sourceware.org/bugzilla/show_bug.cgi?id\x15398

Thank you. This was introduced in 7.2 with support for ADL. Looks like a
bug in types_equal, which doesn't account for cv qualifiers.

>> Saurabh> 2. print k
>> Saurabh> Let's say this prints 0x7ffb24
>> Saurabh> call fn2(0x7ffb24)
>> Saurabh> gdb again says: Cannot resolve function fn2 to any overloaded instance
>> Saurabh> This also used to work with gdb 7.2. Here I can understand if
>> Saurabh> promoting ints to arbitrary pointers is no longer supported.
>>
>> I was under the impression that we allowed this again, but it fails for
>> me too. Please file another bug for this one.
>
> Done: http://sourceware.org/bugzilla/show_bug.cgi?id\x15399

What is "show check type"? If that is enabled/non-zero, gdb will not
allow this conversion. If you disable it ("set check type 0"), it should
work:

(gdb) p fn2(0x7fffffffde14)
Cannot resolve function fn2 to any overloaded instance
(gdb) set check type 0
(gdb) p fn2(0x7fffffffde14)
3
$7 = void

Keith

RE: Problem calling functions within gdb (version 7.5)

[Saurabh T]

----------------------------------------
> Date: Thu, 25 Apr 2013 08:09:31 -0700
> From: keiths@redhat.com
> To: saurabh@hotmail.com
> CC: gdb@sourceware.org
> Subject: Re: Problem calling functions within gdb (version 7.5)
>
> On 04/25/2013 07:24 AM, Saurabh T wrote:
> >> From: tromey@redhat.com
> >>
> >> Saurabh> 1. call fn(3, x)
> >> Saurabh> gdb says: Cannot resolve function fn to any overloaded instance
> >> Saurabh> This used to work with gdb 7.2. The function signature completely
> >> Saurabh> matches the arguments so I dont know what it's complaining about.
> >>
> >> Please file a bug report.
> >
> > Done: http://sourceware.org/bugzilla/show_bug.cgi?id=15398
>
> Thank you. This was introduced in 7.2 with support for ADL. Looks like a
> bug in types_equal, which doesn't account for cv qualifiers.

It was introduced in 7.3. 7.2 works.

>
> >> Saurabh> 2. print k
> >> Saurabh> Let's say this prints 0x7ffb24
> >> Saurabh> call fn2(0x7ffb24)
> >> Saurabh> gdb again says: Cannot resolve function fn2 to any overloaded instance
> >> Saurabh> This also used to work with gdb 7.2. Here I can understand if
> >> Saurabh> promoting ints to arbitrary pointers is no longer supported.
> >>
> >> I was under the impression that we allowed this again, but it fails for
> >> me too. Please file another bug for this one.
> >
> > Done: http://sourceware.org/bugzilla/show_bug.cgi?id=15399
>
> What is "show check type"? If that is enabled/non-zero, gdb will not
> allow this conversion. If you disable it ("set check type 0"), it should
> work:
>
> (gdb) p fn2(0x7fffffffde14)
> Cannot resolve function fn2 to any overloaded instance
> (gdb) set check type 0

This does not work. show check type takes off/on; 0 gives an 
error to me. Neither off nor on print the value. Note that you need to 
compile with g++. Thanks. 		 	   		  
From gdb-return-42056-listarch-gdb=sources.redhat.com@sourceware.org Thu Apr 25 16:12:07 2013
Return-Path: <gdb-return-42056-listarch-gdb=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb@sources.redhat.com
Received: (qmail 14513 invoked by alias); 25 Apr 2013 16:12:06 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Delivered-To: mailing list gdb@sourceware.org
Received: (qmail 14503 invoked by uid 89); 25 Apr 2013 16:12:06 -0000
X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 25 Apr 2013 16:12:05 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3PGC4GL019179	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits%6 verify=OK);	Thu, 25 Apr 2013 12:12:04 -0400
Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3PGC3hh020316	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits%6 verify=NO);	Thu, 25 Apr 2013 12:12:03 -0400
Message-ID: <517955D3.4010101@redhat.com>
Date: Thu, 25 Apr 2013 16:12:00 -0000
From: Keith Seitz <keiths@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5
MIME-Version: 1.0
To: Saurabh T <saurabh@hotmail.com>
CC: "gdb@sourceware.org" <gdb@sourceware.org>
Subject: Re: Problem calling functions within gdb (version 7.5)
References: <DUB123-W3379C1D5569CB0664A9923B1B50@phx.gbl>,<87r4hykai1.fsf@fleche.redhat.com> <DUB123-W1189571D83329779F4BA17B1B60@phx.gbl>,<5179472B.5020107@redhat.com> <DUB123-W41A1167FBF065A8E14CC3B1B60@phx.gbl>
In-Reply-To: <DUB123-W41A1167FBF065A8E14CC3B1B60@phx.gbl>
Content-Type: text/plain; charset=windows-1251; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-04/txt/msg00091.txt.bz2
Content-length: 1452

On 04/25/2013 08:45 AM, Saurabh T wrote:
>> Thank you. This was introduced in 7.2 with support for ADL. Looks like a
>> bug in types_equal, which doesn't account for cv qualifiers.
>
> It was introduced in 7.3. 7.2 works.

Yes, sorry. My bad.

>> What is "show check type"? If that is enabled/non-zero, gdb will not
>> allow this conversion. If you disable it ("set check type 0"), it should
>> work:
>>
>> (gdb) p fn2(0x7fffffffde14)
>> Cannot resolve function fn2 to any overloaded instance
>> (gdb) set check type 0
>
> This does not work. show check type takes off/on; 0 gives an
> error to me. Neither off nor on print the value. Note that you need to
> compile with g++. Thanks.

I am using your example program with G++ 4.7.2 (Fedora 18 system compiler).

Ah, I think I may see the problem. This was fixed /after/ the 7.5 branch
was created, so it doesn't actually appear in an official release yet. I
use CVS HEAD, so I have that patch in my sources.

In that patch, we re-purpose the existing command "set/show check type",
and that is probably why it does nothing for you (because until now, it
never did do anything).

If you grep for "strict" in gdbtypes.c, do you get anything? If not,
your sources do not contain the patch from c++/13356
(http://sourceware.org/bugzilla/show_bug.cgi?id\x13356).

The easiest way to get the patch is to use the git mirror and use commit
e8370ca5. Or I can send it to you privately.

Keith

RE: Problem calling functions within gdb (version 7.5)

[Saurabh T]

> Date: Thu, 25 Apr 2013 09:12:03 -0700
> From: keiths@redhat.com
> To: saurabh@hotmail.com
> CC: gdb@sourceware.org
> Subject: Re: Problem calling functions within gdb (version 7.5)
>
[... snip ...]
>
> The easiest way to get the patch is to use the git mirror and use commit
> e8370ca5. Or I can send it to you privately.
>
> Keith

Thanks, but I rolled back to 7.2 for the first case, and will wait on both the bugs being addressed in an official release. 		 	   		  
From gdb-return-42058-listarch-gdb=sources.redhat.com@sourceware.org Fri Apr 26 02:21:17 2013
Return-Path: <gdb-return-42058-listarch-gdb=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb@sources.redhat.com
Received: (qmail 19998 invoked by alias); 26 Apr 2013 02:21:16 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Delivered-To: mailing list gdb@sourceware.org
Received: (qmail 19987 invoked by uid 89); 26 Apr 2013 02:21:16 -0000
X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1
Received: from mail-vb0-f47.google.com (HELO mail-vb0-f47.google.com) (209.85.212.47)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 26 Apr 2013 02:21:13 +0000
Received: by mail-vb0-f47.google.com with SMTP id x13so3157226vbb.6        for <gdb@sourceware.org>; Thu, 25 Apr 2013 19:21:11 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s 120113;        h=mime-version:x-received:in-reply-to:references:date:message-id         :subject:from:to:cc:content-type:x-gm-message-state;        bh=BTuRzwnwZCxILAX61ANZYLIhq/x8E7KcD7QCYvPrhRw=;        b=ZKTpvVNjbtILWq1p57v8/5gecehg6jMtbFQseah9G0SCoEcmHxAj57sQB7wxHuNw+X         afhPpFo29e+Ll9PKNx7LYoTx2kT5w7htP80o0DuvGWlu0yVNyyy13FhVu4gAYDAlymfO         U4yjoN8IGqOmhMUIEgHXP+tlaJanIysJ+BgshRDT8M4AbGWKvInsTRxIZrjNCLqdx4l6         sIDbY6vWUdP91+nto73wYfT9EckiBsk8+Wwe78HnASGbWU/xran12b63qVvPJDQwJ+Eh         eF1gkxO/HTQ9HEd4rFYSL/3PQFZWa8m+Yn4+anDVBzq0xjLBYEoZQE8d4N8t7hpEIY4e         6vbQ=MIME-Version: 1.0
X-Received: by 10.58.132.232 with SMTP id ox8mr28232434veb.45.1366942871242; Thu, 25 Apr 2013 19:21:11 -0700 (PDT)
Received: by 10.220.173.7 with HTTP; Thu, 25 Apr 2013 19:21:11 -0700 (PDT)
In-Reply-To: <20130425074044.GE3458@adacore.com>
References: <CANFwon0v3pwvC_iJbEnzVp4ZB-B+zphAg-C+hrQqF153P+M_ag@mail.gmail.com>	<20130425064807.GA3458@adacore.com>	<CANFwon0DRN8pT4bpW-Fz=mqsdNqGkjY-bQkeTQ2PprzMQp8CKQ@mail.gmail.com>	<20130425072454.GC3458@adacore.com>	<CANFwon0TkHgc6rNipUWHN5zAwuGPb=oBwQdoJD2nhoWm+Tn=wQ@mail.gmail.com>	<20130425074044.GE3458@adacore.com>
Date: Fri, 26 Apr 2013 02:21:00 -0000
Message-ID: <CADPb22Sq=RoM26gPh5g-C-DX+Z8svFOxRt-aJUTcPOq9JPc-AA@mail.gmail.com>
Subject: Re: New format of 7.6 branch gdb/ChangeLog?
From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Hui Zhu <teawater@gmail.com>, gdb <gdb@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Gm-Message-State: ALoCoQlKMCRYc4OFAk8JzClZgvR3eU/Od1HelfnJSCvUnRHBv1sfB8hawnSqM4bz1Bfj9xv+qLFFrXztrRFHuhSUo2fFkAooFoyI094meMGDsj3NNy/q3gnf/wQCGGY5ypad4M1BeQeAf7sl6V5Sp1Q66m3Wap3UsbVP3qEuA9dmHwTGMQ7CDu/AvrWt/jo1n3B0WNfIPav4
X-SW-Source: 2013-04/txt/msg00093.txt.bz2
Content-length: 565

On Thu, Apr 25, 2013 at 12:40 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> You put the "gdb/" back again. The correct answer is:
>
> 2013-04-24  Hui Zhu  <hui@codesourcery.com>
>
>         PR gdb/15165
>         * breakpoint.c (dprintf_print_recreate): New.
>         (save_breakpoints): Let it not save dprintf commands.
>         (initialize_breakpoint_ops): Set dprintf_print_recreate.

Not to nitpick much :-), but
note the *absence* of a blank line after "PR gdb/15165".

I'm seeing blank lines in other changelog entries,
and they shouldn't be there.