From: Kamil Rytarowski <n54@gmx.com>
To: John Baldwin <jhb@FreeBSD.org>
Cc: gdb@sourceware.org, coypu@sdf.org
Subject: Re: [binutils-gdb] Enable support for x86 debug registers on NetBSD.
Date: Tue, 05 Sep 2017 21:48:00 -0000 [thread overview]
Message-ID: <68aa136b-c248-7ab9-c183-307e45c711f9@gmx.com> (raw)
In-Reply-To: <7b23e1a8-c303-f9f8-3180-9af30a3fb25e@FreeBSD.org>
[-- Attachment #1.1: Type: text/plain, Size: 1420 bytes --]
On 05.09.2017 13:18, John Baldwin wrote:
> On 9/5/17 4:48 AM, Kamil Rytarowski wrote:
>> On 05.09.2017 04:43, John Baldwin wrote:
>>> -/* Not all versions of FreeBSD/i386 that support the debug registers
>>> - have this macro. */
>>> +/* Helper macro to access debug register X. FreeBSD/amd64 and modern
>>> + versions of FreeBSD/i386 provide this macro in system headers. Define
>>> + a local version for systems that do not provide it. */
>>> #ifndef DBREG_DRX
>>> +#ifdef __NetBSD__
>>> +#define DBREG_DRX(d, x) ((d)->dr[x])
>>> +#else
>>> #define DBREG_DRX(d, x) ((&d->dr0)[x])
>>> #endif
>>> +#endif
>>>
>>> static unsigned long
>>> x86bsd_dr_get (ptid_t ptid, int regnum)
>>>
>>
>> Do we support FreeBSD releases developed in year 2002? This macro has
>> point for such old systems as it keeps compat between old and new
>> structure layout.
>
> I have been trimming some older things from GDB master such as support for bsd-uthread
> and FreeBSD/alpha. However, keeping a fallback for this macro doesn't seem to be overly
> onerous or inhibiting maintenance currently.
>
I will submit a patch to refactor it out, however in future.
Right now I keep upstreaming patches to make GDB cleanly buildable.
I've attached a NetBSD buildbot again:
https://gdb-build.sergiodj.net/builders/NetBSD-x86_64-m64
I'm working on patches to sort out all the issues.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-09-05 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170905024337.88051.qmail@sourceware.org>
2017-09-05 8:58 ` Kamil Rytarowski
2017-09-05 11:19 ` John Baldwin
2017-09-05 21:48 ` Kamil Rytarowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68aa136b-c248-7ab9-c183-307e45c711f9@gmx.com \
--to=n54@gmx.com \
--cc=coypu@sdf.org \
--cc=gdb@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox