From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91031 invoked by alias); 5 Sep 2017 21:48:55 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 90240 invoked by uid 89); 5 Sep 2017 21:48:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=trimming, H*c:application X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.15.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Sep 2017 21:48:49 +0000 Received: from [192.168.1.3] ([185.58.161.191]) by mail.gmx.com (mrgmx001 [212.227.17.184]) with ESMTPSA (Nemesis) id 0M2c1V-1dWaIk3ms9-00sQ0E; Tue, 05 Sep 2017 23:48:31 +0200 Subject: Re: [binutils-gdb] Enable support for x86 debug registers on NetBSD. To: John Baldwin Cc: gdb@sourceware.org, coypu@sdf.org References: <20170905024337.88051.qmail@sourceware.org> <53223a37-4aee-76f1-4b5e-131f52cafab0@gmx.com> <7b23e1a8-c303-f9f8-3180-9af30a3fb25e@FreeBSD.org> From: Kamil Rytarowski Message-ID: <68aa136b-c248-7ab9-c183-307e45c711f9@gmx.com> Date: Tue, 05 Sep 2017 21:48:00 -0000 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <7b23e1a8-c303-f9f8-3180-9af30a3fb25e@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Qh5BCwHrAcVDD5LEfLGfK57G5U3WGfv1P" X-UI-Out-Filterresults: notjunk:1;V01:K0:yG+3KkSWXzg=:Wkx3cKaPbdqQQWkYE7k+Gf esKTakRdYppQyEY2FVaq/hsndFcB0+EUEj7P+ljl/P3cgwsPg4Xh7f0dpMtWeKs5nonWPp3so 22/JoxXS5PyR+S3gBzl90068Xcins2ou8b9qORJFZ4BofMUj0wWnLfkDaEcJYz67jIJyO6KBu whylhwnIe+4DaBm2nWw/e5Nb+JS7ua9M8viVnCoY2/89c7JqzT+4dSzkIdkupINEzxm0xyMZg 1Zoi191kjhfJWLCf6GQkcj4NsPh4+DH3K/WAgJ6GsmNen4qbwA3kWVibnDxJnwuVHM+lUpG1C Zl+jHjlrVqUp12rCmVnk8IpkEFfRTSjQGO8Fm3ywSOWD/pkFLnSWszdWSIeGPajBsvWtF/xeR vt8vaBF8y/4FHBaq590ukRzxpfMeMYQgCN+9tWAk3wQp6tIaxOvyEp5b3SJ6mHKUP0m0iD39k lg85Ioi4Lsx5jgkOIaLxk9usmbYWzG621KWRIt6uFHQ4DEELonKxdIy9GmAYh3dLbvSPXKAIE cjIQDeeL7gxfdpagNJGy/Y2HKv3vyiQrGkAjOCnmqAtKVOwHEc+MNoqUg5qtfIX4tGQsybcy1 VaofSW1EYMwGcVle5VKvBmg3EZMYQrR656mTs7aca0RQEepbtlZRJWlNKUsDMqbH1Uokfh5Sk 09L1u++32/IQbriY6yWmMZX6xjDuga2fGatHNzJnQKG1SPro9yY1KvKI5yr0y8I+O6hnxr+Xm 21+jGt7rTfHTHcGjYKsM5MAHQlTokHYfT/d42DJPOE6VYMZIV/NhhUGpSZp/PXJsFdDEJiBS9 XQC1itZStR3OJA5PXbbG9kRjF8EZA== X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00005.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Qh5BCwHrAcVDD5LEfLGfK57G5U3WGfv1P Content-Type: multipart/mixed; boundary="cT79H8CUjcwInIe2bLlpdbILS7A3h2igu"; protected-headers="v1" From: Kamil Rytarowski To: John Baldwin Cc: gdb@sourceware.org, coypu@sdf.org Message-ID: <68aa136b-c248-7ab9-c183-307e45c711f9@gmx.com> Subject: Re: [binutils-gdb] Enable support for x86 debug registers on NetBSD. References: <20170905024337.88051.qmail@sourceware.org> <53223a37-4aee-76f1-4b5e-131f52cafab0@gmx.com> <7b23e1a8-c303-f9f8-3180-9af30a3fb25e@FreeBSD.org> In-Reply-To: <7b23e1a8-c303-f9f8-3180-9af30a3fb25e@FreeBSD.org> --cT79H8CUjcwInIe2bLlpdbILS7A3h2igu Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 1395 On 05.09.2017 13:18, John Baldwin wrote: > On 9/5/17 4:48 AM, Kamil Rytarowski wrote: >> On 05.09.2017 04:43, John Baldwin wrote: >>> -/* Not all versions of FreeBSD/i386 that support the debug registers >>> - have this macro. */ >>> +/* Helper macro to access debug register X. FreeBSD/amd64 and modern >>> + versions of FreeBSD/i386 provide this macro in system headers. Def= ine >>> + a local version for systems that do not provide it. */ >>> #ifndef DBREG_DRX >>> +#ifdef __NetBSD__ >>> +#define DBREG_DRX(d, x) ((d)->dr[x]) >>> +#else >>> #define DBREG_DRX(d, x) ((&d->dr0)[x]) >>> #endif >>> +#endif >>>=20=20 >>> static unsigned long >>> x86bsd_dr_get (ptid_t ptid, int regnum) >>> >> >> Do we support FreeBSD releases developed in year 2002? This macro has >> point for such old systems as it keeps compat between old and new >> structure layout. >=20 > I have been trimming some older things from GDB master such as support fo= r bsd-uthread > and FreeBSD/alpha. However, keeping a fallback for this macro doesn't se= em to be overly > onerous or inhibiting maintenance currently. >=20 I will submit a patch to refactor it out, however in future. Right now I keep upstreaming patches to make GDB cleanly buildable. I've attached a NetBSD buildbot again: https://gdb-build.sergiodj.net/builders/NetBSD-x86_64-m64 I'm working on patches to sort out all the issues. --cT79H8CUjcwInIe2bLlpdbILS7A3h2igu-- --Qh5BCwHrAcVDD5LEfLGfK57G5U3WGfv1P Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZrxxAAAoJEEuzCOmwLnZsy0gQAMBslj+nr0+0tURxOqKxQhQ6 SE3qWz4O2HWVR0lsZBrJY4c1TaQEpglP1BwFiaKnBTaU3UZVEMDdpT6vPAUfrXB+ GjRsE9ORegrLhH/F0NaIVaitD1a3BxcrcKk8ctBT5ZjY+Ajj270d4C576eYTdSkf u64Mq/rz2SjNHakLkeKIwIYDPXO7OTo6EGMoior+YkRJYRZRuQmCPXxCWyYYFv6Q oQ7V3b/YaI8BctY3h/M96Ex+iDcG1iqsWZmgE0kGLJYxZXNGdf607TczXjV6GoVD DjiAxRICkD/2BgGhvIEMmcVMKUo+lgPpFV3v1+fEPcUhXty0kuy4YprYViX9CMHT epN8/gLWGbuzDF2RK5A/WlaWlFTYgHJTh/LBXUuFIlUMcU5lmcIH6WBS0sI4NwAI M7kQIuSsZG98uiBMM0nfT+QM585u+bPdeui2iub07zDbL8qsAk4P3ykTmhRBdNUq aJAtIWLFOGIszhWeQQ9nXJha0W+zxgPF5MihWYCx4yNTkAdGVGm9jIXt9tUXxOby 4kzZntHNwmM8MQ300zk3RVDs5Y/TclOArmA7LaQbCEDtB4PYWpJaVW1SzmbejDXN 2oFRVnb4f1dxpF1RpYdsKksugIWddNaiggNwTIycOy5I6ZU+b8OOVaUFVehhIugE lYwgD7gcLeM1+fIU3utC =F2Vd -----END PGP SIGNATURE----- --Qh5BCwHrAcVDD5LEfLGfK57G5U3WGfv1P--