From: Kamil Rytarowski <n54@gmx.com>
To: John Baldwin <jhb@sourceware.org>
Cc: gdb@sourceware.org, coypu@sdf.org
Subject: Re: [binutils-gdb] Enable support for x86 debug registers on NetBSD.
Date: Tue, 05 Sep 2017 08:58:00 -0000 [thread overview]
Message-ID: <53223a37-4aee-76f1-4b5e-131f52cafab0@gmx.com> (raw)
In-Reply-To: <20170905024337.88051.qmail@sourceware.org>
[-- Attachment #1.1: Type: text/plain, Size: 1090 bytes --]
On 05.09.2017 04:43, John Baldwin wrote:
> -/* Not all versions of FreeBSD/i386 that support the debug registers
> - have this macro. */
> +/* Helper macro to access debug register X. FreeBSD/amd64 and modern
> + versions of FreeBSD/i386 provide this macro in system headers. Define
> + a local version for systems that do not provide it. */
> #ifndef DBREG_DRX
> +#ifdef __NetBSD__
> +#define DBREG_DRX(d, x) ((d)->dr[x])
> +#else
> #define DBREG_DRX(d, x) ((&d->dr0)[x])
> #endif
> +#endif
>
> static unsigned long
> x86bsd_dr_get (ptid_t ptid, int regnum)
>
Do we support FreeBSD releases developed in year 2002? This macro has
point for such old systems as it keeps compat between old and new
structure layout.
"bsdphk committed on 20 Oct 2002"
https://github.com/freebsd/freebsd/commit/6c70e7ba980490dd092e728144518733eed32383
I think we are now ready to just drop it entirely. I've deliberately
decided to not include them on NetBSD.
Another place that it keeps dusting is in wine.
Regardless thanks for committing the patches!
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next parent reply other threads:[~2017-09-05 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170905024337.88051.qmail@sourceware.org>
2017-09-05 8:58 ` Kamil Rytarowski [this message]
2017-09-05 11:19 ` John Baldwin
2017-09-05 21:48 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53223a37-4aee-76f1-4b5e-131f52cafab0@gmx.com \
--to=n54@gmx.com \
--cc=coypu@sdf.org \
--cc=gdb@sourceware.org \
--cc=jhb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox